New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set S3 Select record message length to 128KiB #7475
Conversation
- Previously this limit was a little more than 1MiB, and it broke compatibility with AWS SDK Java causing a buffer overflow error.
Mint Automation
7475-687268b/mint-dist-xl.sh.log:
7475-687268b/mint-compression-xl.sh.log:
7475-687268b/mint-large-bucket.sh.log:
|
Codecov Report
@@ Coverage Diff @@
## master #7475 +/- ##
==========================================
+ Coverage 48.05% 48.06% +<.01%
==========================================
Files 296 296
Lines 46725 46732 +7
==========================================
+ Hits 22453 22460 +7
Misses 22198 22198
Partials 2074 2074
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Updates minio#7475 The Java implementation has a 128KB buffer and a message must be emitted before that is used. minio#7475 therefore limits the message size to 128KB. But up to 256 bytes are written to the buffer in each call. This means we must emit a message before shorter than 128KB. Therefore we change the limit to 128KB minus 256 bytes.
Updates #7475 The Java implementation has a 128KB buffer and a message must be emitted before that is used. #7475 therefore limits the message size to 128KB. But up to 256 bytes are written to the buffer in each call. This means we must emit a message before shorter than 128KB. Therefore we change the limit to 128KB minus 256 bytes.
compatibility with AWS SDK Java causing a buffer overflow error.
Regression
No
How Has This Been Tested?
Types of changes
Checklist:
mint
PR # here: )