Minor TLS documentation improvements

[parnigot]

Description

From my limited understanding of the code, the server key/certificate file names are hardcoded here and cannot be changed. The user can only supply the path to the certs directory containing these two files.

But the TLS documentation isn't really clear on this:

Copy the existing private key and public certificate to the certs directory

and:

The key and certificate files must be appended with .key and .crt, respectively.

For clarity I've included in the second phrase to include the names public.crt and private.key. (I've lost way to much time trying to understand why minio wasn't picking up my <hostname>.crt and hostname.key files :D ).

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added unit tests to cover my changes.
• I have added/updated functional tests in mint. (If yes, add mint PR # here: )
• All new and existing tests passed.

[codecov]

Codecov Report

Merging #7592 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #7592      +/-   ##
==========================================
+ Coverage   47.35%   47.35%   +<.01%     
==========================================
  Files         295      295              
  Lines       46785    46785              
==========================================
+ Hits        22153    22156       +3     
+ Misses      22581    22579       -2     
+ Partials     2051     2050       -1

Impacted Files	Coverage Δ
cmd/fs-v1-helpers.go	68.8% <0%> (+0.61%)	⬆️
cmd/retry.go	87.5% <0%> (+1.78%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b93ef73...4638977. Read the comment docs.

[minio-ops]

Mint Automation

Test	Result
mint-xl.sh	✔️
mint-compression-fs.sh	✔️
mint-worm.sh	✔️
mint-gateway-nas.sh	✔️
mint-compression-xl.sh	❌ more...
mint-large-bucket.sh	❌ more...
mint-compression-dist-xl.sh	❌ more...
mint-fs.sh	❌ more...
mint-dist-xl.sh	❌ more...

7592-4638977/mint-dist-xl.sh.log:

Running with
SERVER_ENDPOINT:      72.28.97.52:30065
ACCESS_KEY:           minio
SECRET_KEY:           ***REDACTED***
ENABLE_HTTPS:         0
SERVER_REGION:        us-east-1
MINT_DATA_DIR:        /mint/data
MINT_MODE:            full
ENABLE_VIRTUAL_STYLE: 0

To get logs, run 'docker cp 7d2ffb396f23:/mint/log /tmp/mint-logs'

(1/14) Running aws-sdk-go tests ... done in 1 seconds
(2/14) Running aws-sdk-java tests ... done in 1 seconds
(3/14) Running aws-sdk-php tests ... done in 52 seconds
(4/14) Running aws-sdk-ruby tests ... done in 5 seconds
(5/14) Running awscli tests ... done in 1 minutes and 52 seconds
(6/14) Running healthcheck tests ... done in 1 seconds
(7/14) Running mc tests ... done in 30 seconds
(8/14) Running minio-dotnet tests ... done in 45 seconds
(9/14) Running minio-go tests ... done in 1 minutes and 34 seconds
(10/14) Running minio-java tests ... done in 5 minutes and 52 seconds
(11/14) Running minio-js tests ... done in 48 seconds
(12/14) Running minio-py tests ... FAILED in 9 minutes and 37 seconds
{
  "error": "Traceback (most recent call last):\n  File \"/mint/run/core/minio-py/tests.py\", line 1220, in test_presigned_get_object_expiry_5sec\n    object_name).get_exception()\nminio.error.AccessDenied: AccessDenied: message: Access Denied\n\nDuring handling of the above exception, another exception occurred:\n\nTraceback (most recent call last):\n  File \"/mint/run/core/minio-py/tests.py\", line 1885, in main\n    test_presigned_get_object_expiry_5sec(client, log_output)\n  File \"/mint/run/core/minio-py/tests.py\", line 1228, in test_presigned_get_object_expiry_5sec\n    raise Exception(err)\nException: AccessDenied: message: Access Denied\n",
  "name": "minio-py:test_presigned_get_object_expiry_5sec",
  "args": {
    "object_name": "588b17ef-02f7-4196-9772-3dc524442fe6",
    "bucket_name": "minio-py-test-eb3e38ee-ae63-4d54-9713-e0129bc224a6"
  },
  "function": "presigned_get_object(bucket_name, object_name, expires, response_headers, request_date)",
  "message": "AccessDenied: message: Access Denied",
  "status": "FAIL",
  "duration": 265
}

Executed 11 out of 14 tests successfully.

7592-4638977/mint-compression-xl.sh.log:

Running with
SERVER_ENDPOINT:      72.28.97.52:31446
ACCESS_KEY:           minio
SECRET_KEY:           ***REDACTED***
ENABLE_HTTPS:         0
SERVER_REGION:        us-east-1
MINT_DATA_DIR:        /mint/data
MINT_MODE:            full
ENABLE_VIRTUAL_STYLE: 0

To get logs, run 'docker cp b6efe863acdf:/mint/log /tmp/mint-logs'

(1/14) Running aws-sdk-go tests ... done in 0 seconds
(2/14) Running aws-sdk-java tests ... done in 1 seconds
(3/14) Running aws-sdk-php tests ... FAILED in 1 seconds
{
  "name": "aws-sdk-php",
  "function": "listObjects ( array $params = [] )",
  "args": {
    "Bucket": "aws-sdk-php-5cc48bee97f63",
    "Object": "obj1"
  },
  "duration": "402",
  "status": "FAIL",
  "error": "Error executing \"CopyObject\" on \"http://72.28.97.52:31446/aws-sdk-php-5cc48bee97f63/obj1-copy-0\"; AWS HTTP error: Server error: `PUT http://72.28.97.52:31446/aws-sdk-php-5cc48bee97f63/obj1-copy-0` resulted in a `503 Service Unavailable` response:\n<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n<Error><Code>XMinioReadQuorum</Code><Message>Multiple disk failures, unable to re (truncated...)\n XMinioReadQuorum (server): Multiple disk failures, unable to reconstruct data. - <?xml version=\"1.0\" encoding=\"UTF-8\"?>\n<Error><Code>XMinioReadQuorum</Code><Message>Multiple disk failures, unable to reconstruct data.</Message><Key>obj1-copy-0</Key><BucketName>aws-sdk-php-5cc48bee97f63</BucketName><Resource>/aws-sdk-php-5cc48bee97f63/obj1-copy-0</Resource><RequestId>159963AF5C9AA0C5</RequestId><HostId>bb7bce50-7503-4f6f-b668-cd6a374041fa</HostId></Error>"
}

Executed 2 out of 14 tests successfully.

7592-4638977/mint-large-bucket.sh.log:

Running with
SERVER_ENDPOINT:      72.28.97.57:30709
ACCESS_KEY:           minio
SECRET_KEY:           ***REDACTED***
ENABLE_HTTPS:         0
SERVER_REGION:        us-east-1
MINT_DATA_DIR:        /mint/data
MINT_MODE:            full
ENABLE_VIRTUAL_STYLE: 0

To get logs, run 'docker cp 823a0c6a3158:/mint/log /tmp/mint-logs'

(1/14) Running aws-sdk-go tests ... FAILED in 6 minutes and 0 seconds
{
  "alert": "",
  "args": {
    "bucketName": "aws-sdk-go-test-vhzvpdzl39urq9",
    "expiry": 60000000000,
    "objectName": "presignedTest"
  },
  "duration": 360012,
  "error": "XMinioServerNotInitialized: Server not initialized, please try again.\n\tstatus code: 503, request id: 15996403049BD09B, host id: ",
  "function": "PresignedPut",
  "message": "AWS SDK Go CreateBucket Failed",
  "name": "aws-sdk-go",
  "status": "FAIL"
}

Executed 0 out of 14 tests successfully.

7592-4638977/mint-fs.sh.log:

Running with
SERVER_ENDPOINT:      72.28.97.52:30179
ACCESS_KEY:           minio
SECRET_KEY:           ***REDACTED***
ENABLE_HTTPS:         0
SERVER_REGION:        us-east-1
MINT_DATA_DIR:        /mint/data
MINT_MODE:            full
ENABLE_VIRTUAL_STYLE: 0

To get logs, run 'docker cp bf7439b755f9:/mint/log /tmp/mint-logs'

(1/14) Running aws-sdk-go tests ... FAILED in 1 seconds
{
  "alert": "",
  "args": {
    "bucketName": "aws-sdk-go-test-ph9qtu243nqzsb",
    "expiry": 60000000000,
    "objectName": "presignedTest"
  },
  "duration": 368,
  "error": "RequestError: send request failed\ncaused by: Put http://72.28.97.52:30179/aws-sdk-go-test-ph9qtu243nqzsb: dial tcp 72.28.97.52:30179: connect: connection refused",
  "function": "PresignedPut",
  "message": "AWS SDK Go CreateBucket Failed",
  "name": "aws-sdk-go",
  "status": "FAIL"
}

Executed 0 out of 14 tests successfully.

7592-4638977/mint-compression-dist-xl.sh.log:

Running with
SERVER_ENDPOINT:      72.28.97.56:30126
ACCESS_KEY:           minio
SECRET_KEY:           ***REDACTED***
ENABLE_HTTPS:         0
SERVER_REGION:        us-east-1
MINT_DATA_DIR:        /mint/data
MINT_MODE:            full
ENABLE_VIRTUAL_STYLE: 0

To get logs, run 'docker cp 319e6e2b579d:/mint/log /tmp/mint-logs'

(1/14) Running aws-sdk-go tests ... done in 1 seconds
(2/14) Running aws-sdk-java tests ... done in 1 seconds
(3/14) Running aws-sdk-php tests ... FAILED in 0 seconds
{
  "name": "aws-sdk-php",
  "function": "listObjects ( array $params = [] )",
  "args": {
    "Bucket": "aws-sdk-php-5cc48bf02e747",
    "Object": "obj1"
  },
  "duration": "538",
  "status": "FAIL",
  "error": "Error executing \"CopyObject\" on \"http://72.28.97.56:30126/aws-sdk-php-5cc48bf02e747/obj1-copy-0\"; AWS HTTP error: Server error: `PUT http://72.28.97.56:30126/aws-sdk-php-5cc48bf02e747/obj1-copy-0` resulted in a `503 Service Unavailable` response:\n<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n<Error><Code>XMinioReadQuorum</Code><Message>Multiple disk failures, unable to re (truncated...)\n XMinioReadQuorum (server): Multiple disk failures, unable to reconstruct data. - <?xml version=\"1.0\" encoding=\"UTF-8\"?>\n<Error><Code>XMinioReadQuorum</Code><Message>Multiple disk failures, unable to reconstruct data.</Message><Key>obj1-copy-0</Key><BucketName>aws-sdk-php-5cc48bf02e747</BucketName><Resource>/aws-sdk-php-5cc48bf02e747/obj1-copy-0</Resource><RequestId>159963AFC3B58468</RequestId><HostId>60b2ad2f-fdec-4b8a-9939-75010d222550</HostId></Error>"
}

Executed 2 out of 14 tests successfully.

[eco-minio]

LGTM