Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove logs from bitrot-streaming.go as erasure layer is already logging #7603

Merged
merged 2 commits into from May 2, 2019

Conversation

krishnasrinivas
Copy link
Contributor

Description

Currently we are logging at bitrot-writer and erasure-encode which can flood logs on console (i.e logs related to same S3 object upload). Hence removing logs from streaming-bitrot-writer.

Motivation and Context

To have less logs

Regression

No

How Has This Been Tested?

By simulating failure scenarios (ctrl-C the curl)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added unit tests to cover my changes.
  • I have added/updated functional tests in mint. (If yes, add mint PR # here: )
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented May 1, 2019

Codecov Report

Merging #7603 into master will decrease coverage by 0.03%.
The diff coverage is 60%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7603      +/-   ##
==========================================
- Coverage    47.4%   47.36%   -0.04%     
==========================================
  Files         293      293              
  Lines       46781    46769      -12     
==========================================
- Hits        22176    22153      -23     
- Misses      22552    22561       +9     
- Partials     2053     2055       +2
Impacted Files Coverage Δ
cmd/bitrot-streaming.go 83.69% <60%> (-3.81%) ⬇️
cmd/xl-sets.go 40.07% <0%> (-1.77%) ⬇️
cmd/posix.go 62.63% <0%> (-0.2%) ⬇️
cmd/fs-v1-helpers.go 68.8% <0%> (+0.61%) ⬆️
cmd/os-reliable.go 65.04% <0%> (+1.94%) ⬆️
cmd/retry.go 87.5% <0%> (+5.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5f26d5...c2b386a. Read the comment docs.

@kannappanr kannappanr requested review from vadmeste and krisis May 1, 2019 04:18
Copy link
Member

@vadmeste vadmeste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@minio-ops
Copy link

Mint Automation

Test Result
mint-compression-xl.sh ✔️
mint-large-bucket.sh ✔️
mint-compression-dist-xl.sh ✔️
mint-compression-fs.sh ✔️
mint-worm.sh ✔️
mint-fs.sh ✔️
mint-dist-xl.sh ✔️
mint-gateway-nas.sh ✔️
mint-xl.sh more...

7603-c2b386a/mint-xl.sh.log:

Running with
SERVER_ENDPOINT:      72.28.97.61:30174
ACCESS_KEY:           minio
SECRET_KEY:           ***REDACTED***
ENABLE_HTTPS:         0
SERVER_REGION:        us-east-1
MINT_DATA_DIR:        /mint/data
MINT_MODE:            full
ENABLE_VIRTUAL_STYLE: 0

To get logs, run 'docker cp 843ac0b5059a:/mint/log /tmp/mint-logs'

(1/14) Running aws-sdk-go tests ... FAILED in 6 minutes and 0 seconds
{
  "alert": "",
  "args": {
    "bucketName": "aws-sdk-go-test-h6nfoqilvi5xgo",
    "expiry": 60000000000,
    "objectName": "presignedTest"
  },
  "duration": 360010,
  "error": "XMinioServerNotInitialized: Server not initialized, please try again.\n\tstatus code: 503, request id: 159AB83A915BDC0A, host id: ",
  "function": "PresignedPut",
  "message": "AWS SDK Go CreateBucket Failed",
  "name": "aws-sdk-go",
  "status": "FAIL"
}

Executed 0 out of 14 tests successfully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants