Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto-heal: Use fast scan instead of the deep one #7868

Merged
merged 1 commit into from
Jul 3, 2019

Conversation

vadmeste
Copy link
Member

@vadmeste vadmeste commented Jul 2, 2019

Description

Deep scan is slow and consumes a lot of resources, disabling it for now. Users can still use mc admin to trigger the deep scan

How to test this PR?

  1. minio server /tmp/xl/{1..4}/
  2. mc mb myminio/testbucket/
  3. mc cp file myminio/testbucket/
  4. rm /tmp/xl/1/testbucket/file/
  5. Restart minio server to trigger auto healing and check the heal in the backend

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Documentation needed
  • Unit tests needed
  • Functional tests needed (If yes, add mint PR # here: )

Copy link
Contributor

@kannappanr kannappanr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@harshavardhana harshavardhana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vadmeste

@minio-ops
Copy link

Mint Automation

Test Result
mint-compression-xl.sh ✔️
mint-xl.sh ✔️
mint-compression-dist-xl.sh ✔️
mint-compression-fs.sh ✔️
mint-worm.sh ✔️
mint-fs.sh ✔️
mint-gateway-nas.sh ✔️
mint-large-bucket.sh more...
mint-dist-xl.sh more...

7868-2934ebc/mint-dist-xl.sh.log:

Running with
SERVER_ENDPOINT:      72.28.97.61:31991
ACCESS_KEY:           minio
SECRET_KEY:           ***REDACTED***
ENABLE_HTTPS:         0
SERVER_REGION:        us-east-1
MINT_DATA_DIR:        /mint/data
MINT_MODE:            full
ENABLE_VIRTUAL_STYLE: 0

To get logs, run 'docker cp 552acba9cea3:/mint/log /tmp/mint-logs'

(1/14) Running aws-sdk-go tests ... done in 0 seconds
(2/14) Running aws-sdk-java tests ... done in 1 seconds
(3/14) Running aws-sdk-php tests ... done in 43 seconds
(4/14) Running aws-sdk-ruby tests ... done in 3 seconds
(5/14) Running awscli tests ... done in 2 minutes and 2 seconds
(6/14) Running healthcheck tests ... done in 0 seconds
(7/14) Running mc tests ... FAILED in 50 seconds
{
  "name": "mc",
  "duration": "11269",
  "function": "test_mirror_list_objects_storage_class",
  "status": "FAIL",
  "error": "/mint/run/core/mc/mc --config-dir /tmp/.mc-14395 --quiet --no-color rb --force myminio/mc-test-bucket-13678  >>> \nmc: <ERROR> Failed to remove `myminio/mc-test-bucket-13678`. The bucket you tried to delete is not empty."
}

Executed 6 out of 14 tests successfully.

7868-2934ebc/mint-large-bucket.sh.log:

Running with
SERVER_ENDPOINT:      72.28.97.57:32695
ACCESS_KEY:           minio
SECRET_KEY:           ***REDACTED***
ENABLE_HTTPS:         0
SERVER_REGION:        us-east-1
MINT_DATA_DIR:        /mint/data
MINT_MODE:            full
ENABLE_VIRTUAL_STYLE: 0

To get logs, run 'docker cp 4b12f2f3c5b5:/mint/log /tmp/mint-logs'

(1/14) Running aws-sdk-go tests ... FAILED in 3 seconds
{
  "alert": "",
  "args": {
    "bucketName": "aws-sdk-go-test-a0jzea0qflxv3u",
    "expiry": 60000000000,
    "objectName": "presignedTest"
  },
  "duration": 3076,
  "error": "RequestError: send request failed\ncaused by: Put http://72.28.97.57:32695/aws-sdk-go-test-a0jzea0qflxv3u: dial tcp 72.28.97.57:32695: connect: no route to host",
  "function": "PresignedPut",
  "message": "AWS SDK Go CreateBucket Failed",
  "name": "aws-sdk-go",
  "status": "FAIL"
}

Executed 0 out of 14 tests successfully.

@codecov
Copy link

codecov bot commented Jul 3, 2019

Codecov Report

Merging #7868 into master will increase coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7868      +/-   ##
==========================================
+ Coverage   46.06%   46.07%   +0.01%     
==========================================
  Files         299      299              
  Lines       48654    48654              
==========================================
+ Hits        22412    22419       +7     
+ Misses      24156    24150       -6     
+ Partials     2086     2085       -1
Impacted Files Coverage Δ
cmd/daily-heal-ops.go 0% <0%> (ø) ⬆️
cmd/posix.go 62.1% <0%> (-0.39%) ⬇️
cmd/fs-v1.go 61.34% <0%> (-0.38%) ⬇️
cmd/fs-v1-helpers.go 68.18% <0%> (+1.81%) ⬆️
cmd/os-reliable.go 63.1% <0%> (+3.88%) ⬆️
pkg/certs/certs.go 58.76% <0%> (+4.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0bcd8ab...2934ebc. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants