New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix type conversion in UpdateKey
for Vault
#8058
Conversation
This commit fixes a type conversion in the `UpdateKey` implementation of Vault.
Mint Automation
8058-f6f54e2/mint-xl.sh.log:
8058-f6f54e2/mint-large-bucket.sh.log:
|
Codecov Report
@@ Coverage Diff @@
## master #8058 +/- ##
==========================================
+ Coverage 45.02% 45.02% +<.01%
==========================================
Files 321 321
Lines 51387 51387
==========================================
+ Hits 23137 23138 +1
+ Misses 26098 26097 -1
Partials 2152 2152
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
This commit fixes a type conversion in the
UpdateKey
implementation of Vault.
Motivation and Context
Thanks to @sinhaashish
How to test this PR?
Setup Vault: https://github.com/minio/minio/tree/master/docs/kms
Pull: #7955
Start a MinIO server with Vault configuration and configure
/pkg/madmin/examples/key-status.go
with the correct access/secret key.Run:
go run github.com/minio/minio/pkg/madmin/examples/key-status.go
Types of changes
Checklist:
commit-id
orPR #
here)