Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve browser README #9628

Merged
merged 1 commit into from May 18, 2020
Merged

Improve browser README #9628

merged 1 commit into from May 18, 2020

Conversation

darkdragon-001
Copy link
Contributor

Description

Improve browser README.md

  • Add instructions to download node dependencies
  • Add instructions to allow development from IPs other than localhost

Motivation and Context

Easier contribution.

How to test this PR?

Documentation

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Documentation improved
  • Unit tests needed
  • Functional tests needed (If yes, add mint PR # here: )

- Add instructions to download node dependencies
- Add instructions to allow development from IPs other than localhost
@minio-trusted
Copy link
Contributor

Mint Automation

Test Result
mint-xl.sh ✔️
mint-large-bucket.sh ✔️
mint-fs.sh ✔️
mint-dist-xl.sh ✔️
mint-gateway-s3.sh ✔️
mint-gateway-azure.sh ✔️
mint-gateway-nas.sh ✔️
Deleting image on docker hub
Deleting image locally

@kannappanr kannappanr merged commit a3f41c7 into minio:master May 18, 2020
@darkdragon-001 darkdragon-001 deleted the browser-readme branch May 18, 2020 18:52
blaenk pushed a commit to blaenk/minio that referenced this pull request Aug 26, 2020
- Add instructions to download node dependencies
- Add instructions to allow development from IPs other than localhost
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants