Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change madmin SetBucketQuota API signature #9669

Merged
merged 1 commit into from May 21, 2020

Conversation

poornas
Copy link
Contributor

@poornas poornas commented May 21, 2020

to allow both setting and removing quota config.

Description

Motivation and Context

RemoveBucketQuota API was recently removed - change SetBucketQuota to accept BucketQuota as parameter instead of expecting quota and type to be set individually.

How to test this PR?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Documentation needed
  • Unit tests needed
  • Functional tests needed (If yes, add mint PR # here: )

to allow both setting and removing quota config.
@minio-trusted
Copy link
Contributor

Mint Automation

Test Result
mint-xl.sh ✔️
mint-large-bucket.sh ✔️
mint-fs.sh ✔️
mint-dist-xl.sh ✔️
mint-gateway-s3.sh ✔️
mint-gateway-azure.sh ✔️
mint-gateway-nas.sh ✔️
Deleting image on docker hub
Deleting image locally

@harshavardhana harshavardhana merged commit f1f414c into minio:master May 21, 2020
blaenk pushed a commit to blaenk/minio that referenced this pull request Aug 26, 2020
@poornas poornas deleted the fixquotaAPI branch June 13, 2022 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants