Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set Lock with empty parameters #9677

Merged
merged 1 commit into from May 22, 2020
Merged

Set Lock with empty parameters #9677

merged 1 commit into from May 22, 2020

Conversation

sinhaashish
Copy link
Contributor

Description

This PR enables to set lock with empty parameters.
Details in issue #9676

Closes #9676

Motivation and Context

How to test this PR?

Steps in issue #9676

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Documentation needed
  • Unit tests needed
  • Functional tests needed (If yes, add mint PR # here: )

@sinhaashish sinhaashish mentioned this pull request May 22, 2020
Merged
@minio-trusted
Copy link
Contributor

Mint Automation

Test Result
mint-xl.sh ✔️
mint-large-bucket.sh ✔️
mint-fs.sh ✔️
mint-dist-xl.sh ✔️
mint-gateway-s3.sh ✔️
mint-gateway-azure.sh ✔️
mint-gateway-nas.sh ✔️
Deleting image on docker hub
Deleting image locally

kannappanr
kannappanr approved these changes May 22, 2020
View reviewed changes
Copy link
Contributor

@kannappanr kannappanr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kannappanr kannappanr merged commit bede525 into minio:master May 22, 2020
blaenk pushed a commit to blaenk/minio that referenced this pull request Aug 26, 2020
@sinhaashish @danochoa
bypass flag: Allow object retention removal (minio#9677)
f8e2814
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshavardhana harshavardhana harshavardhana approved these changes

@kannappanr kannappanr kannappanr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to set new lock with empty parameters.
4 participants
@sinhaashish @minio-trusted @harshavardhana @kannappanr