Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid '\n' from constant strings #9737

Merged
merged 1 commit into from
May 29, 2020
Merged

Avoid '\n' from constant strings #9737

merged 1 commit into from
May 29, 2020

Conversation

harshavardhana
Copy link
Member

Description

Avoid '\n' from constant strings

Motivation and Context

Fixes #9736

How to test this PR?

Use the ansible tool mentioned in the issue #9736

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression in a way yes
  • Documentation needed
  • Unit tests needed
  • Functional tests needed (If yes, add mint PR # here: )

kannappanr
kannappanr approved these changes May 29, 2020
View reviewed changes
Copy link
Contributor

@kannappanr kannappanr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vadmeste
vadmeste approved these changes May 29, 2020
View reviewed changes
Copy link
Member

@vadmeste vadmeste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harshavardhana harshavardhana merged commit 2bcb02f into minio:master May 29, 2020
@harshavardhana harshavardhana deleted the fix-incorrect branch May 29, 2020 18:41
@minio-trusted
Copy link
Contributor

Mint Automation

Test Result
mint-xl.sh ✔️
mint-large-bucket.sh ✔️
mint-fs.sh ✔️
mint-dist-xl.sh ✔️
mint-gateway-s3.sh ✔️
mint-gateway-azure.sh ✔️
mint-gateway-nas.sh ✔️
Deleting image on docker hub
Deleting image locally

blaenk pushed a commit to blaenk/minio that referenced this pull request Aug 26, 2020
@harshavardhana @danochoa
Avoid '\n' from constant strings (minio#9737)
c906e80 
Fixes minio#9736
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vadmeste vadmeste vadmeste approved these changes

@kannappanr kannappanr kannappanr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalid xml received when creating a bucket
4 participants
@harshavardhana @minio-trusted @vadmeste @kannappanr