Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow deleting of dropped multiparts #9753

Merged
merged 1 commit into from
Jun 2, 2020

Conversation

harshavardhana
Copy link
Member

Description

allow deleting of dropped multiparts

Motivation and Context

bonus change trigger MRF heal when single
offline disk is found, break out early.

How to test this PR?

Use aws cli to drop the parts during complete multipart,
this hasn't been working for a while now found this during
versioning PR change and also bonus change to
fix the MRF healing.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Documentation needed
  • Unit tests needed
  • Functional tests needed (If yes, add mint PR # here: )

Copy link
Member

@vadmeste vadmeste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bonus change trigger MRF heal when single
offline disk is found, break out early.
@minio-trusted
Copy link
Contributor

Mint Automation

Test Result
mint-xl.sh ✔️
mint-large-bucket.sh ✔️
mint-fs.sh ✔️
mint-dist-xl.sh ✔️
mint-gateway-s3.sh ✔️
mint-gateway-azure.sh ✔️
mint-gateway-nas.sh ✔️
Deleting image on docker hub
Deleting image locally

Copy link
Contributor

@kannappanr kannappanr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kannappanr kannappanr merged commit 566e0e2 into minio:master Jun 2, 2020
@harshavardhana harshavardhana deleted the fix-mul branch June 2, 2020 22:28
blaenk pushed a commit to blaenk/minio that referenced this pull request Aug 26, 2020
bonus change trigger MRF heal when single
offline disk is found, break out early.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants