Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CodeQL security scanning #9763

Merged
merged 2 commits into from
Jun 3, 2020
Merged

Add CodeQL security scanning #9763

merged 2 commits into from
Jun 3, 2020

Conversation

jhutchings1
Copy link
Contributor

Hi, I'm a PM on the GitHub security team. This repository is eligible to try the new GitHub Advanced Security code scanning beta.

Code scanning runs a static analysis tool called CodeQL which scans your code at build time to find any potential security issues. We've tuned the set of queries to be only the most severe, most precise issues. We'll show alerts in the security tab, and we'll show alerts for any net new vulnerabilities on pull requests as well. We've tried to make this super developer friendly, but we'd love your feedback as we work through the beta.

If you're interested in trying it out, you can merge this pull request to set up the Actions workflow.

@harshavardhana
Copy link
Member

@jhutchings1 thanks for the PR - we would love to use CodeQL, looks like the PR is sent for a Java project we are a Go project can this be changed accordingly?

@harshavardhana harshavardhana self-requested a review June 3, 2020 16:39
Auto-detection found Java code, but that doesn't seem to actually be in the repo. Adding the override excludes that.
@jhutchings1
Copy link
Contributor Author

Thanks @harshavardhana. It looks like the auto-language detection detected Java for some reason, but I've excluded it and started the build again.

@harshavardhana harshavardhana marked this pull request as ready for review June 3, 2020 17:17
@kannappanr kannappanr merged commit b91040f into minio:master Jun 3, 2020
@minio-trusted
Copy link
Contributor

Mint Automation

Test Result
mint-xl.sh ✔️
mint-large-bucket.sh ✔️
mint-fs.sh ✔️
mint-dist-xl.sh ✔️
mint-gateway-s3.sh ✔️
mint-gateway-azure.sh ✔️
mint-gateway-nas.sh ✔️
Deleting image on docker hub
Deleting image locally

@jhutchings1
Copy link
Contributor Author

Thanks @kannappanr and @harshavardhana! If you're game, I'm happy to send PRs for the other Go, Python, or JavaScript repos in your org to get you jumpstarted. I've got a script that makes this easy, so just let me know!

We also support other languages (C, C++, C#, Java), but the build configuration on those is occasionally more involved, so that's more likely to require work from a maintainer.

@harshavardhana
Copy link
Member

Thanks @kannappanr and @harshavardhana! If you're game, I'm happy to send PRs for the other Go, Python, or JavaScript repos in your org to get you jumpstarted. I've got a script that makes this easy, so just let me know!

We also support other languages (C, C++, C#, Java), but the build configuration on those is occasionally more involved, so that's more likely to require work from a maintainer.

Please do happy for all the work GitHub has done here.

blaenk pushed a commit to blaenk/minio that referenced this pull request Aug 26, 2020
Manually specify go and javascript for analysis
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants