Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix NAS gateway support for policy/notification #9765

Merged
merged 1 commit into from
Jun 3, 2020
Merged

fix NAS gateway support for policy/notification #9765

merged 1 commit into from
Jun 3, 2020

Conversation

harshavardhana
Copy link
Member

Description

fix NAS gateway support for policy/notification

Motivation and Context

Fixes #9764

How to test this PR?

All tests related to policy should run fine

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression introduced in the bucket metadata refactor
  • Documentation needed
  • Unit tests needed
  • Functional tests needed (If yes, add mint PR # here: )

poornas
poornas approved these changes Jun 3, 2020
View reviewed changes
Copy link
Contributor

@poornas poornas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@minio-trusted
Copy link
Contributor

Mint Automation

Test Result
mint-xl.sh ✔️
mint-large-bucket.sh ✔️
mint-fs.sh ✔️
mint-dist-xl.sh ✔️
mint-gateway-s3.sh ✔️
mint-gateway-azure.sh ✔️
mint-gateway-nas.sh ✔️
Deleting image on docker hub
Deleting image locally

kannappanr
kannappanr approved these changes Jun 3, 2020
View reviewed changes
Copy link
Contributor

@kannappanr kannappanr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. LGTM

@kannappanr kannappanr merged commit 5686a7e into minio:master Jun 3, 2020
@harshavardhana harshavardhana deleted the fix-value branch June 3, 2020 20:22
blaenk pushed a commit to blaenk/minio that referenced this pull request Aug 26, 2020
@harshavardhana @danochoa
fix NAS gateway support for policy/notification (minio#9765)
334172c 
Fixes minio#9764
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poornas poornas poornas approved these changes

@kannappanr kannappanr kannappanr approved these changes

Assignees
No one assigned
Labels
priority: high
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bucket policies are broken in gateway nas mode
4 participants
@harshavardhana @minio-trusted @poornas @kannappanr