Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: throw error if symmetry cannot be obtained #9780

Merged
merged 2 commits into from Jun 7, 2020

Conversation

harshavardhana
Copy link
Member

@harshavardhana harshavardhana commented Jun 6, 2020

Description

fix: throw an error if symmetry cannot be obtained

Motivation and Context

For example {1...17}/{1...52} symmetrical
distribution of drives cannot be obtained

  • Because 17 is a prime number
  • Is not divisible by any pre-defined setCounts i.e
    from 1 to 16

How to test this PR?

Just try to start the server as minio server /tmp/data{1...17}/drives{1...52} it would crash with
current master, this throws an appropriate error.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Documentation needed
  • Unit tests needed
  • Functional tests needed (If yes, add mint PR # here: )

For example `{1...17}/{1...52}` symmetrical
distribution of drives cannot be obtained

- Because 17 is a prime number
- Is not divisible by any pre-defined setCounts i.e
  from 1 to 16
cmd/endpoint-ellipses.go Outdated Show resolved Hide resolved
Co-authored-by: poornas <poornas@users.noreply.github.com>
@minio-trusted
Copy link
Contributor

Mint Automation

Test Result
mint-xl.sh ✔️
mint-large-bucket.sh ✔️
mint-fs.sh ✔️
mint-dist-xl.sh ✔️
mint-gateway-s3.sh ✔️
mint-gateway-azure.sh ✔️
mint-gateway-nas.sh ✔️
Deleting image on docker hub
Deleting image locally

Copy link
Contributor

@kannappanr kannappanr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kannappanr kannappanr merged commit c7599d3 into minio:master Jun 7, 2020
@harshavardhana harshavardhana deleted the fix-crash branch June 7, 2020 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants