Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix formatting and wording. #9784

Merged
merged 2 commits into from Jun 9, 2020
Merged

Fix formatting and wording. #9784

merged 2 commits into from Jun 9, 2020

Conversation

kerneltime
Copy link
Contributor

@kerneltime kerneltime commented Jun 8, 2020 •
edited by harshavardhana

The formatted page https://docs.min.io/docs/distributed-minio-quickstart-guide.html is
not formatted correctly. Trying out this formatting to see if it fixes it. Also, altering the wording.

Description

Motivation and Context

How to test this PR?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Documentation needed
  • Unit tests needed
  • Functional tests needed (If yes, add mint PR # here: )

@kerneltime
Fix formatting and wording.
beca59a 
The formatted page https://docs.min.io/docs/distributed-minio-quickstart-guide.html is not formatted correctly. Trying out this formatting to see if it fixes it.
Also, altering the wording.
eco-minio
eco-minio requested changes Jun 8, 2020
View reviewed changes
docs/distributed/README.md Outdated Show resolved Hide resolved
@harshavardhana @eco-minio
Update docs/distributed/README.md
1c70a85 
Co-authored-by: Eco <41090896+eco-minio@users.noreply.github.com>
@minio-trusted
Copy link
Contributor

Mint Automation

Test Result
mint-xl.sh ✔️
mint-large-bucket.sh ✔️
mint-fs.sh ✔️
mint-dist-xl.sh ✔️
mint-gateway-s3.sh ✔️
mint-gateway-azure.sh ✔️
mint-gateway-nas.sh ✔️
Deleting image on docker hub
Deleting image locally

eco-minio
eco-minio approved these changes Jun 9, 2020
View reviewed changes
Copy link
Contributor

@eco-minio eco-minio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harshavardhana harshavardhana merged commit 920b863 into master Jun 9, 2020
@harshavardhana harshavardhana deleted the kerneltime-patch-1 branch June 9, 2020 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshavardhana harshavardhana harshavardhana approved these changes

@eco-minio eco-minio eco-minio approved these changes

@nitisht nitisht Awaiting requested review from nitisht

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kerneltime @minio-trusted @harshavardhana @eco-minio