Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: initialize config once per startup #9851

Merged
merged 1 commit into from
Jun 17, 2020
Merged

fix: initialize config once per startup #9851

merged 1 commit into from
Jun 17, 2020

Conversation

harshavardhana
Copy link
Member

Description

fix: initialize config once per startup

Motivation and Context

avoid any config leaks as must

How to test this PR?

This PR is meant to avoid any double initialization
when lookupConfigs gets repeatedly used.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Documentation needed
  • Unit tests needed
  • Functional tests needed (If yes, add mint PR # here: )

kannappanr
kannappanr approved these changes Jun 17, 2020
View reviewed changes
Copy link
Contributor

@kannappanr kannappanr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@minio-trusted
Copy link
Contributor

Mint Automation

Test Result
mint-fs.sh ✔️
mint-gateway-s3.sh ✔️
mint-gateway-azure.sh ✔️
mint-gateway-nas.sh ✔️
mint-xl.sh ❌ more...
mint-large-bucket.sh ❌ more...
mint-dist-xl.sh ❌ more...

9851-07fd25a/mint-dist-xl.sh.log:

Running with
SERVER_ENDPOINT:      minio-dev4.minio.io:32244
ACCESS_KEY:           minio
SECRET_KEY:           ***REDACTED***
ENABLE_HTTPS:         0
SERVER_REGION:        us-east-1
MINT_DATA_DIR:        /mint/data
MINT_MODE:            full
ENABLE_VIRTUAL_STYLE: 0

To get logs, run 'docker cp 2e3df153d829:/mint/log /tmp/mint-logs'

(1/15) Running aws-sdk-go tests ... done in 1 seconds
(2/15) Running aws-sdk-java tests ... done in 1 seconds
(3/15) Running aws-sdk-php tests ... done in 43 seconds
(4/15) Running aws-sdk-ruby tests ... done in 3 seconds
(5/15) Running awscli tests ... done in 2 minutes and 23 seconds
(6/15) Running healthcheck tests ... done in 0 seconds
(7/15) Running mc tests ... done in 1 minutes and 1 seconds
(8/15) Running minio-dotnet tests ... done in 44 seconds
(9/15) Running minio-go tests ... FAILED in 58 seconds
{
  "args": {
    "bucketName": "minio-go-test-hd1v5fyt0zyctj34",
    "objectName": "e0m6akegmi4bamujrhzxdigz1chs9r",
    "objectPrefix": "",
    "recursive": "true"
  },
  "duration": 4813,
  "error": "The bucket you tried to delete is not empty. You must delete all versions in the bucket.",
  "function": "RemoveObjectsWithOptions(bucketName, objectsCh, opts)",
  "message": "Cleanup failed",
  "name": "minio-go: testRemoveObjectsWithOptions",
  "status": "FAIL"
}
(9/15) Running minio-java tests ... FAILED in 1 minutes and 57 seconds
{
  "name": "minio-java",
  "function": "enableObjectLegalHold(String bucketName, String objectName, String versionId)",
  "duration": 550,
  "status": "FAIL",
  "error": "error occurred\nErrorResponse(code = BucketNotEmpty, message = The bucket you tried to delete is not empty. You must delete all versions in the bucket., bucketName = minio-java-test-365psvh, objectName = null, resource = /minio-java-test-365psvh, requestId = 1619338CA7E57665, hostId = 41702916-642b-4ce5-8683-51e57ec48c12)\nrequest={method=DELETE, url=http://minio-dev4.minio.io:32244/minio-java-test-365psvh, headers=Host: minio-dev4.minio.io:32244\nAccept-Encoding: identity\nUser-Agent: MinIO (amd64; amd64) minio-java/dev\nContent-MD5: 1B2M2Y8AsgTpgAmY7PhCfg==\nx-amz-content-sha256: e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855\nx-amz-date: 20200617T022342Z\nAuthorization: AWS4-HMAC-SHA256 Credential=*REDACTED*/20200617/us-east-1/s3/aws4_request, SignedHeaders=accept-encoding;content-md5;host;x-amz-content-sha256;x-amz-date, Signature=*REDACTED*\n}\nresponse={code=409, headers=Accept-Ranges: bytes\nContent-Length: 373\nContent-Security-Policy: block-all-mixed-content\nContent-Type: application/xml\nServer: MinIO/DEVELOPMENT.2020-06-17T02-09-54Z\nVary: Origin\nX-Amz-Request-Id: 1619338CA7E57665\nX-Xss-Protection: 1; mode=block\nDate: Wed, 17 Jun 2020 02:23:42 GMT\n}\n >>> [io.minio.MinioClient.execute(MinioClient.java:1211), io.minio.MinioClient.execute(MinioClient.java:1236), io.minio.MinioClient.executeDelete(MinioClient.java:1366), io.minio.MinioClient.removeBucket(MinioClient.java:3686), FunctionalTest.enableObjectLegalHold_test(FunctionalTest.java:3314), FunctionalTest.runTests(FunctionalTest.java:4079), FunctionalTest.main(FunctionalTest.java:4192)]"
}
(9/15) Running minio-js tests ... done in 55 seconds
(10/15) Running minio-py tests ... done in 2 minutes and 4 seconds
(11/15) Running s3cmd tests ... done in 20 seconds
(12/15) Running s3select tests ... done in 5 seconds
(13/15) Running security tests ... done in 0 seconds

Executed 13 out of 15 tests successfully.

9851-07fd25a/mint-large-bucket.sh.log:

Running with
SERVER_ENDPOINT:      minio-dev3.minio.io:30148
ACCESS_KEY:           minio
SECRET_KEY:           ***REDACTED***
ENABLE_HTTPS:         0
SERVER_REGION:        us-east-1
MINT_DATA_DIR:        /mint/data
MINT_MODE:            full
ENABLE_VIRTUAL_STYLE: 0

To get logs, run 'docker cp 52a1c7d597e8:/mint/log /tmp/mint-logs'

(1/15) Running aws-sdk-go tests ... done in 6 seconds
(2/15) Running aws-sdk-java tests ... done in 2 seconds
(3/15) Running aws-sdk-php tests ... done in 47 seconds
(4/15) Running aws-sdk-ruby tests ... done in 11 seconds
(5/15) Running awscli tests ... done in 2 minutes and 44 seconds
(6/15) Running healthcheck tests ... done in 0 seconds
(7/15) Running mc tests ... done in 57 seconds
(8/15) Running minio-dotnet tests ... done in 1 minutes and 10 seconds
(9/15) Running minio-go tests ... FAILED in 1 minutes and 42 seconds
{
  "args": {
    "bucketName": "minio-go-test-w922ye4sd332idku",
    "objectName": "b4fdl5bg9t13hjgw26qme4tsv9ntqq",
    "objectPrefix": "",
    "recursive": "true"
  },
  "duration": 3949,
  "error": "The bucket you tried to delete is not empty. You must delete all versions in the bucket.",
  "function": "RemoveObjectsWithOptions(bucketName, objectsCh, opts)",
  "message": "Cleanup failed",
  "name": "minio-go: testRemoveObjectsWithOptions",
  "status": "FAIL"
}
(9/15) Running minio-java tests ... FAILED in 6 minutes and 21 seconds
{
  "name": "minio-java",
  "function": "enableObjectLegalHold(String bucketName, String objectName, String versionId)",
  "duration": 915,
  "status": "FAIL",
  "error": "error occurred\nErrorResponse(code = BucketNotEmpty, message = The bucket you tried to delete is not empty. You must delete all versions in the bucket., bucketName = minio-java-test-1jg6f2c, objectName = null, resource = /minio-java-test-1jg6f2c, requestId = 161933E237D1B5C2, hostId = 896a5913-6397-4955-8f3c-7b396454be5a)\nrequest={method=DELETE, url=http://minio-dev3.minio.io:30148/minio-java-test-1jg6f2c, headers=Host: minio-dev3.minio.io:30148\nAccept-Encoding: identity\nUser-Agent: MinIO (amd64; amd64) minio-java/dev\nContent-MD5: 1B2M2Y8AsgTpgAmY7PhCfg==\nx-amz-content-sha256: e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855\nx-amz-date: 20200617T022949Z\nAuthorization: AWS4-HMAC-SHA256 Credential=*REDACTED*/20200617/us-east-1/s3/aws4_request, SignedHeaders=accept-encoding;content-md5;host;x-amz-content-sha256;x-amz-date, Signature=*REDACTED*\n}\nresponse={code=409, headers=Accept-Ranges: bytes\nContent-Length: 373\nContent-Security-Policy: block-all-mixed-content\nContent-Type: application/xml\nServer: MinIO/DEVELOPMENT.2020-06-17T02-09-54Z\nVary: Origin\nX-Amz-Request-Id: 161933E237D1B5C2\nX-Xss-Protection: 1; mode=block\nDate: Wed, 17 Jun 2020 02:29:49 GMT\n}\n >>> [io.minio.MinioClient.execute(MinioClient.java:1211), io.minio.MinioClient.execute(MinioClient.java:1236), io.minio.MinioClient.executeDelete(MinioClient.java:1366), io.minio.MinioClient.removeBucket(MinioClient.java:3686), FunctionalTest.enableObjectLegalHold_test(FunctionalTest.java:3314), FunctionalTest.runTests(FunctionalTest.java:4079), FunctionalTest.main(FunctionalTest.java:4192)]"
}
(9/15) Running minio-js tests ... done in 55 seconds
(10/15) Running minio-py tests ... done in 5 minutes and 48 seconds
(11/15) Running s3cmd tests ... done in 27 seconds
(12/15) Running s3select tests ... done in 16 seconds
(13/15) Running security tests ... done in 0 seconds

Executed 13 out of 15 tests successfully.

9851-07fd25a/mint-xl.sh.log:

Running with
SERVER_ENDPOINT:      minio-dev4.minio.io:30685
ACCESS_KEY:           minio
SECRET_KEY:           ***REDACTED***
ENABLE_HTTPS:         0
SERVER_REGION:        us-east-1
MINT_DATA_DIR:        /mint/data
MINT_MODE:            full
ENABLE_VIRTUAL_STYLE: 0

To get logs, run 'docker cp cc7862508329:/mint/log /tmp/mint-logs'

(1/15) Running aws-sdk-go tests ... done in 0 seconds
(2/15) Running aws-sdk-java tests ... done in 1 seconds
(3/15) Running aws-sdk-php tests ... done in 42 seconds
(4/15) Running aws-sdk-ruby tests ... done in 2 seconds
(5/15) Running awscli tests ... done in 2 minutes and 18 seconds
(6/15) Running healthcheck tests ... done in 0 seconds
(7/15) Running mc tests ... done in 31 seconds
(8/15) Running minio-dotnet tests ... done in 32 seconds
(9/15) Running minio-go tests ... FAILED in 51 seconds
{
  "args": {
    "bucketName": "minio-go-test-gedkv35sr9ko0wxa",
    "objectName": "3g1htwwbkri0mufidfx45xs2qg0rhl",
    "objectPrefix": "",
    "recursive": "true"
  },
  "duration": 2256,
  "error": "The bucket you tried to delete is not empty. You must delete all versions in the bucket.",
  "function": "RemoveObjectsWithOptions(bucketName, objectsCh, opts)",
  "message": "Cleanup failed",
  "name": "minio-go: testRemoveObjectsWithOptions",
  "status": "FAIL"
}
(9/15) Running minio-java tests ... FAILED in 50 seconds
{
  "name": "minio-java",
  "function": "enableObjectLegalHold(String bucketName, String objectName, String versionId)",
  "duration": 115,
  "status": "FAIL",
  "error": "error occurred\nErrorResponse(code = BucketNotEmpty, message = The bucket you tried to delete is not empty. You must delete all versions in the bucket., bucketName = minio-java-test-3gvij6r, objectName = null, resource = /minio-java-test-3gvij6r, requestId = 1619336FA273E59C, hostId = 60000c80-1da1-4623-adc3-2c73abbc743c)\nrequest={method=DELETE, url=http://minio-dev4.minio.io:30685/minio-java-test-3gvij6r, headers=Host: minio-dev4.minio.io:30685\nAccept-Encoding: identity\nUser-Agent: MinIO (amd64; amd64) minio-java/dev\nContent-MD5: 1B2M2Y8AsgTpgAmY7PhCfg==\nx-amz-content-sha256: e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855\nx-amz-date: 20200617T022137Z\nAuthorization: AWS4-HMAC-SHA256 Credential=*REDACTED*/20200617/us-east-1/s3/aws4_request, SignedHeaders=accept-encoding;content-md5;host;x-amz-content-sha256;x-amz-date, Signature=*REDACTED*\n}\nresponse={code=409, headers=Accept-Ranges: bytes\nContent-Length: 373\nContent-Security-Policy: block-all-mixed-content\nContent-Type: application/xml\nServer: MinIO/DEVELOPMENT.2020-06-17T02-09-54Z\nVary: Origin\nX-Amz-Request-Id: 1619336FA273E59C\nX-Xss-Protection: 1; mode=block\nDate: Wed, 17 Jun 2020 02:21:37 GMT\n}\n >>> [io.minio.MinioClient.execute(MinioClient.java:1211), io.minio.MinioClient.execute(MinioClient.java:1236), io.minio.MinioClient.executeDelete(MinioClient.java:1366), io.minio.MinioClient.removeBucket(MinioClient.java:3686), FunctionalTest.enableObjectLegalHold_test(FunctionalTest.java:3314), FunctionalTest.runTests(FunctionalTest.java:4079), FunctionalTest.main(FunctionalTest.java:4192)]"
}
(9/15) Running minio-js tests ... done in 45 seconds
(10/15) Running minio-py tests ... done in 1 minutes and 15 seconds
(11/15) Running s3cmd tests ... done in 18 seconds
(12/15) Running s3select tests ... done in 3 seconds
(13/15) Running security tests ... done in 0 seconds

Executed 13 out of 15 tests successfully.

Deleting image on docker hub
Deleting image locally

@harshavardhana harshavardhana merged commit f5e1b3d into minio:master Jun 17, 2020
@harshavardhana harshavardhana deleted the etcd-duplicate branch June 17, 2020 03:15
harshavardhana added a commit that referenced this pull request Jun 17, 2020
@harshavardhana
fix: initialize config once per startup (#9851)
98a8a5c
harshavardhana added a commit to harshavardhana/minio that referenced this pull request Jun 18, 2020
@harshavardhana
allow loading some from config and some values from ENVs
d273ef5 
A regression perhaps introduced in minio#9851
@harshavardhana harshavardhana mentioned this pull request Jun 18, 2020
Merged
7 tasks
harshavardhana added a commit to harshavardhana/minio that referenced this pull request Jun 18, 2020
@harshavardhana
allow loading some from config and some values from ENVs
34da733 
A regression perhaps introduced in minio#9851
harshavardhana added a commit that referenced this pull request Jun 19, 2020
@harshavardhana
allow loading some from config and some values from ENVs (#9872)
fa13fe2 
A regression perhaps introduced in #9851
harshavardhana added a commit that referenced this pull request Jun 19, 2020
@harshavardhana
allow loading some from config and some values from ENVs (#9872)
0513ac7 
A regression perhaps introduced in #9851
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poornas poornas poornas approved these changes

@kannappanr kannappanr kannappanr approved these changes

@vadmeste vadmeste Awaiting requested review from vadmeste

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@harshavardhana @minio-trusted @poornas @kannappanr