Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always add existing cache when skipping #9862

Merged
merged 2 commits into from
Jun 17, 2020

Conversation

klauspost
Copy link
Contributor

@klauspost klauspost commented Jun 17, 2020

Description

Always add existing cache values, even when skipping.

ONLY for release branch.

#9579 scans bloom filters in another place, but it seems this was not included in the latest release.

Fixes intermediate missing buckets and skipped lifecycle checks.

Types of changes

  • Bug fix

Always add existing cache values, even when skipping.

ONLY FOR release branch.
@minio-trusted
Copy link
Contributor

Mint Automation

Test Result
mint-xl.sh ✔️
mint-large-bucket.sh ✔️
mint-fs.sh ✔️
mint-dist-xl.sh ✔️
mint-gateway-s3.sh ✔️
mint-gateway-azure.sh ✔️
mint-gateway-nas.sh ✔️
Deleting image on docker hub
Deleting image locally

@harshavardhana
Copy link
Member

43d6e3a this PR was merged before we made the release branches @klauspost

If this change is needed in release it is needed in master as well.

@klauspost
Copy link
Contributor Author

@harshavardhana It seems you missed some bloom filter code when merging into your versioning change. See #9861 which re-adds it.

@harshavardhana
Copy link
Member

@harshavardhana It seems you missed some bloom filter code when merging into your versioning change. See #9861 which re-adds it.

Ah but release shouldn't need this change ? Do you agree? Because it was merged as is from the PR.

@klauspost
Copy link
Contributor Author

@harshavardhana It is fixing a bug in the currently released version with bloom filters. See SUBNET 814. master completely skips bloom filters which the other PR is for.

@harshavardhana
Copy link
Member

@harshavardhana It is fixing a bug in the currently released version with bloom filters. See SUBNET 814. master completely skips bloom filters which the other PR is for.

So we need to make another release with this or is it good to use -14 without this?

@klauspost
Copy link
Contributor Author

It (the currently released version) delivers inconsistent totals. They diverge quite a lot since entire buckets can be missing.

@harshavardhana harshavardhana merged commit a649589 into minio:release Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants