-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for JSON logging format in minio-js #137
Conversation
@@ -0,0 +1,38 @@ | |||
var mocha = require('mocha'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
License header is needed..
Discussed with @kannappanr the issues will be fixed after minio/minio-js#621 gets merged. This is the current output:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently the log format is not compliant to the format finalized earlier. Issues with the format are
function
shows a message instead of API being testedargs
are not shown
c7fde2d
to
050c02c
Compare
Add reporter file to display the logs in JSON format. Change the way the program is called in run.sh to remove unwanted log message generated. update the version of Minio-JS to 3.2.1 in ./build/minio-js/install.sh Fixes minio#136
8289407
to
b003325
Compare
Tested with latest release, couple of issues
|
Discussed with @kannappanr on this, log entries can be tweaked later based on confirmation with @abperiasamy , meanwhile we can take this PR in, as the format is overall compliant with json format |
Add reporter file and the corresponding change in run script and package json to support JSON logging format in minio-js.
Fixes (#136)