Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add endpoint information at startup. #169

Merged
merged 1 commit into from
Oct 3, 2017
Merged

add endpoint information at startup. #169

merged 1 commit into from
Oct 3, 2017

Conversation

balamurugana
Copy link
Member

No description provided.

@nitisht
Copy link
Contributor

nitisht commented Sep 30, 2017

Can we put this info in the log.json, that will be more helpful I think. Something like

{SERVER_ENDPOINT: "", ACCESS_KEY: "", ENABLE_HTTPS: "", SERVER_REGION: "",
MINT_DATA_DIR: "", MINT_MODE: ""}

as the first entry and then the test logs?

@balamurugana
Copy link
Member Author

balamurugana commented Sep 30, 2017

Adding into log.json would make dynamic json file i.e. the first log entry is not compatible with other known json structure. Is this expected?

@nitisht
Copy link
Contributor

nitisht commented Sep 30, 2017

Adding into log.json would make dynamic json file i.e. the first log entry is not compatible with other known json structure.

Yes that is true. But is that a problem? I mean while parsing logs we can start from second entry.

Also, we can add an entry called timestamp like

{SERVER_ENDPOINT: "", ACCESS_KEY: "", ENABLE_HTTPS: "", SERVER_REGION: "",
MINT_DATA_DIR: "", MINT_MODE: "", TEST_RUN_TIME:""}

It will help keep track of multiple mint runs happening in automation.

@balamurugana
Copy link
Member Author

You can skip first line. This needs to be documented. According to JSON it is multi-lined document. This requires more discussion and I would recommend your requirement needs to be fixed in different PR

@nitisht
Copy link
Contributor

nitisht commented Sep 30, 2017

This requires more discussion and I would recommend your requirement needs to be fixed in different PR

Okay I will create an issue with the details.

Copy link
Contributor

@poornas poornas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like it would be good to separate sdk level "detail" logs from run summary logs - the env flags used by Mint would fall in the latter category along with details like average runtime for the sdk.

echo "SECRET_KEY: ***REDACTED***"
echo "ENABLE_HTTPS: $ENABLE_HTTPS"
echo "SERVER_REGION: $SERVER_REGION"
echo "MINT_DATA_DIR: $MINT_DATA_DIR"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any way for us to pass MINT_DATA_DIR? If not, should we log it here?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that the value for MINT_DATA_DIR can be passed via environment variable.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. for non-docker env i.e. when we run it by hand

Copy link
Collaborator

@kannappanr kannappanr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@balamurugana balamurugana merged commit 8db72de into minio:master Oct 3, 2017
@balamurugana balamurugana deleted the show-info-about-endpoints branch October 3, 2017 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants