Fix aws ruby and minio-js behavior when invalid endpoint is passed #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure that aws-sdk-ruby and minio-js report failure,when wrong credentials are passed. Fixes minio#164
nitisht
approved these changes
Oct 2, 2017
There was a problem hiding this comment.
Tested locally, LGTM
Status: Downloaded newer image for play.minio.io/mint:travis-dc309243a1af5f7813e8bd6badabcf2324e02305
To get intermittent logs, 'sudo docker cp b62040b146d1:/mint/log /tmp/mint-logs'
Running aws-sdk-php tests ... FAILED in 0 seconds
Running aws-sdk-ruby tests ... FAILED in 1 seconds
Running awscli tests ... FAILED in 1 seconds
Running mc tests ... FAILED in 1 seconds
Running minio-go tests ... FAILED in 0 seconds
Running minio-java tests ... FAILED in 0 seconds
Running minio-js tests ... FAILED in 1 seconds
Running minio-py tests ... FAILED in 0 seconds
Finished running all tests.
To get logs, run 'sudo docker cp b62040b146d1:/mint/log /tmp/mint-logs'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure that aws-sdk-ruby and minio-js report failure,when
wrong credentials are passed.
Fixes #164