Add s3cmd tests. #182
Add s3cmd tests. #182
Conversation
build/s3cmd/install.sh
Outdated
| exit 1 | ||
| fi | ||
|
|
||
| pip3 install s3cmd==$S3CMD_VERSION |
There was a problem hiding this comment.
As package version is optional to pip, you can install latest s3cmd by pip3 install s3cmd
| @@ -0,0 +1,2 @@ | |||
| *~ | |||
| *.log | |||
run/core/s3cmd/test.sh
Outdated
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| # | ||
|
|
There was a problem hiding this comment.
Can you style/logic of https://github.com/minio/mc/blob/master/functional-tests.sh?
There was a problem hiding this comment.
Why .. I based this on awscli?
There was a problem hiding this comment.
current awscli code is bug prone, unclean and not simple. I suggested the team to clean awscli too.
|
Tests updated @balamurugana @nitisht to be more |
There was a problem hiding this comment.
LGTM & Tested. One comment regarding logs:
As per our last discussion, logs should be formatted like this
{
"name": "s3cmd/test_make_bucket",
"duration": "424",
"function": "mb",
"args": {
bucketName: ""
}
"status": "PASS"
}
and so on. We can either fix it here or take it up in next pod.
run/core/s3cmd/test.sh
Outdated
| log_success "$start_time" "${FUNCNAME[0]}" | ||
| } | ||
|
|
||
| function test_cp_object() |
There was a problem hiding this comment.
you can name this as test_copy_object() for more readability.
No description provided.