fix: show last error appropriately #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nitisht
reviewed
Oct 22, 2017
mint.sh
Outdated
| fi | ||
| ## Show error.log when status is empty or not "FAIL". | ||
| ## This may happen when test run failed without providing logs. | ||
| if [ "$err" -ne 0 -o -z "$tatus" -o "$status" != "FAIL" ]; then |
There was a problem hiding this comment.
s/"$tatus"/"$status"
also, shellcheck complains
^-- SC2166: Prefer [ p ] || [ q ] as [ p -o q ] is not well defined.
nitisht
reviewed
Oct 22, 2017
mint.sh
Outdated
| @@ -117,8 +129,7 @@ function main() | |||
| done | |||
| fi | |||
|
|
|||
| echo "Finished running all tests." | |||
| echo "To get logs, run 'sudo docker cp ${CONTAINER_ID}:/mint/log /tmp/mint-logs'" | |||
| echo "All tests ran successfully" | |||
There was a problem hiding this comment.
This statement should be printed only in case of successful run of tests, currently it is like this
Running with
SERVER_ENDPOINT: 127.0.0.1:9000
ACCESS_KEY: minio
SECRET_KEY: ***REDACTED***
ENABLE_HTTPS: 0
SERVER_REGION: us-east-1
MINT_DATA_DIR: /mint/data
MINT_MODE: core
To get logs, run 'sudo docker cp 80b4b3caa433:/mint/log /tmp/mint-logs'
Running minio-java tests ... FAILED in 0 seconds
Error: A JNI error has occurred, please check your installation and try again
Exception in thread "main" java.lang.NoClassDefFoundError: okhttp3/RequestBody
at java.lang.Class.getDeclaredMethods0(Native Method)
at java.lang.Class.privateGetDeclaredMethods(Class.java:2701)
at java.lang.Class.privateGetMethodRecursive(Class.java:3048)
at java.lang.Class.getMethod0(Class.java:3018)
at java.lang.Class.getMethod(Class.java:1784)
at sun.launcher.LauncherHelper.validateMainClass(LauncherHelper.java:544)
at sun.launcher.LauncherHelper.checkAndLoadMain(LauncherHelper.java:526)
Caused by: java.lang.ClassNotFoundException: okhttp3.RequestBody
at java.net.URLClassLoader.findClass(URLClassLoader.java:381)
at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:335)
at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
... 7 more
All tests ran successfully
On test failure, show appropriate error message by showing JSON message or error.log
nitisht
approved these changes
Oct 22, 2017
harshavardhana
approved these changes
Oct 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On test failure, show appropriate error message by showing JSON
message or error.log