Use uniqid() to generate randomName for buckets #208

krisis · 2017-10-27T09:03:49Z

This will reduce the possibility of bucket names being same across mint
runs on the same (object storage) endpoint.

Fixes #196

This will reduce the possibility of bucket names being same across mint runs on the same (object storage) endpoint.

nitisht

LGTM

ebozduman

Maybe a comment that says

 # generates a unique id in the form 'aws-sdk-php-<current time in microseconds as 13 chars>'

can be added.
Never mind! You already have a comment.

Use uniqid() to generate randomName for buckets

54d615d

This will reduce the possibility of bucket names being same across mint runs on the same (object storage) endpoint.

nitisht requested review from nitisht and ebozduman October 27, 2017 15:19

nitisht approved these changes Oct 27, 2017

View reviewed changes

ebozduman reviewed Oct 27, 2017

View reviewed changes

ebozduman approved these changes Oct 27, 2017

View reviewed changes

nitisht merged commit 27ac639 into minio:master Oct 27, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use uniqid() to generate randomName for buckets #208

Use uniqid() to generate randomName for buckets #208

krisis commented Oct 27, 2017

nitisht left a comment

ebozduman left a comment •

edited

Loading

Use uniqid() to generate randomName for buckets #208

Use uniqid() to generate randomName for buckets #208

Conversation

krisis commented Oct 27, 2017

nitisht left a comment

Choose a reason for hiding this comment

ebozduman left a comment • edited Loading

Choose a reason for hiding this comment

ebozduman left a comment •

edited

Loading