Fail if directory passed from cmd line doesn't exist #210
Conversation
mint.sh
Outdated
| fi | ||
| (( i++ )) | ||
| done | ||
|
|
||
| echo "Finished running all tests." |
There was a problem hiding this comment.
@nitisht , your changes are good - but noticed that we echo "Finished running all tests" even if one of the sdk runs failed. You could check whether your counter i matches the total # of sdks in the run_list and print accurate message of how many sdks passed.
There was a problem hiding this comment.
Updated the PR @poornas
nitisht
force-pushed
the
non-existing-dir
branch
from
93b4e92
to
f01fd29
Compare
mint.sh
Outdated
| echo -n "($i/$count) Running $sdk_name tests ... " | ||
| if ! run_test "$sdk_dir"; then | ||
| break | ||
| if [ -d "$sdk_dir" ]; then |
There was a problem hiding this comment.
You could do for minimal diff
if [ ! -d "$sdk_dir" ]; then
echo Test directory "$sdk_name" not found. Exiting Mint.
exit 1
fi
mint.sh
Outdated
| fi | ||
| (( i++ )) | ||
| else | ||
| echo Test directory "$sdk_name" not found. Exiting Mint. |
There was a problem hiding this comment.
Quote the entire string. You should say "Test $sdk_name not found"
mint.sh
Outdated
| done | ||
|
|
||
| echo "Finished running all tests." | ||
| ## Report when all tests in run_list are run | ||
| if [ $i -eq $((count + 1)) ]; then |
There was a problem hiding this comment.
IMO you would need to do this as separate PR
There was a problem hiding this comment.
sure, will do @balamurugana
nitisht
force-pushed
the
non-existing-dir
branch
from
f01fd29
to
ad64a4c
Compare
|
Updated PR @balamurugana |
mint.sh
Outdated
| @@ -125,6 +125,10 @@ function main() | |||
| i=1 | |||
| for sdk_dir in "${run_list[@]}"; do | |||
| sdk_name=$(basename "$sdk_dir") | |||
| if [ ! -d "$sdk_dir" ]; then | |||
| echo "Test directory $sdk_name not found. Exiting Mint." | |||
| exit 1 | |||
There was a problem hiding this comment.
Test directory is not useful to the user. You could print test not found
nitisht
force-pushed
the
non-existing-dir
branch
from
ad64a4c
to
29701c2
Compare
Mint accepts command line args to run specific tests. This PR adds a check to make sure the test directory exists before attempting to run tests.