Add aws-sdk-go presigned PUT test #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nitisht
suggested changes
Nov 16, 2017
run/core/aws-sdk-go/quick-tests.go
Outdated
| // calculate the test case duration | ||
| duration := time.Since(startTime) | ||
| // log with the fields as per mint | ||
| fields := log.Fields{"name": "minio-go", "function": function, "args": args, "duration": duration.Nanoseconds() / 1000000, "status": "pass"} |
There was a problem hiding this comment.
log field name should be aws-sdk-go
run/core/aws-sdk-go/quick-tests.go
Outdated
| var fields log.Fields | ||
| // log with the fields as per mint | ||
| if err != nil { | ||
| fields = log.Fields{"name": "minio-go", "function": function, "args": args, |
run/core/aws-sdk-go/quick-tests.go
Outdated
| fields = log.Fields{"name": "minio-go", "function": function, "args": args, | ||
| "duration": duration.Nanoseconds() / 1000000, "status": "fail", "alert": alert, "message": message, "error": err} | ||
| } else { | ||
| fields = log.Fields{"name": "minio-go", "function": function, "args": args, |
- Add aws-sdk-go to mint - Add presigned PUT test in aws-sdk-go - Remove presigned PUT tests in aws-sdk-php since the SDK doesn't support 'X-Amz-Content-Sha256' header with presigned requests
|
Ping @ebozduman |
ebozduman
approved these changes
Nov 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'X-Amz-Content-Sha256' header with presigned requests
Fixes #216