awscli: Create directory prefix first before uploading object #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nitisht
suggested changes
Nov 22, 2017
run/core/awscli/test.sh
Outdated
| if [ $rv -eq 0 ]; then | ||
| function="${AWS} s3api put-object --body ${MINT_DATA_DIR}/datafile-1-MB --bucket ${bucket_name} --key prefix/directory/datafile-1-MB" | ||
| touch /tmp/zero-byte-file | ||
| function="${AWS} s3api put-object --body /tmp/zero-byte-file --bucket ${bucket_name} --key prefix/directory/" |
There was a problem hiding this comment.
put-object with no --body works as well. I mean ${AWS} s3api put-object --bucket ${bucket_name} --key prefix/directory/
run/core/awscli/test.sh
Outdated
| else | ||
| # if make_bucket fails, $bucket_name has the error output | ||
| out="${bucket_name}" | ||
| fi | ||
|
|
||
| # if make bucket succeeds upload a file |
harshavardhana
force-pushed
the
fix-test
branch
from
80429e2
to
6cb2b05
Compare
nitisht
approved these changes
Nov 22, 2017
krisis
approved these changes
Nov 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #231