Overwriting directories should succeed #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vadmeste
reviewed
Mar 1, 2018
run/core/awscli/test.sh
Outdated
| @@ -190,6 +190,18 @@ function test_lookup_object_prefix() { | |||
| if [ $rv -eq 0 ]; then | |||
| function="${AWS} s3api put-object --bucket ${bucket_name} --key prefix/directory/" | |||
| out=$($function 2>&1) | |||
|
|
|||
There was a problem hiding this comment.
We might need to save function in test_function before we continue.
vadmeste
reviewed
Mar 1, 2018
run/core/awscli/test.sh
Outdated
| ## Attempt an overwrite of the prefix again and should succeed as well. | ||
| function="${AWS} s3api put-object --bucket ${bucket_name} --key prefix/directory/" | ||
| out=$($function 2>&1) | ||
|
|
harshavardhana
force-pushed
the
over-write
branch
from
231f98f
to
dcb2115
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #259
Fixes #258