The awscli tests for virtual style paths (dnsmasq fix) #278

Praveenrajmani · 2018-05-31T17:42:14Z

The dnsmasq will now accept wildcard bucket name entries.

The container is spawned by

docker run -e "SERVER_ENDPOINT=192.168.86.133:9000" \ -e "DOMAIN=minio.com" -e "ACCESS_KEY=minio" \ -e "SECRET_KEY=**REDACTED**" -e "ENABLE_HTTPS=0" \ -e "ENABLE_VIRTUAL_STYLE=1" minio/mint awscli

The DOMAIN provided in the env will be resolved to the host ip in SERVER_ENDPOINT

Fixes: #213

Mint awscli tests now run against both path style and virtual style if virtual style flag is set. By default only path style tests are run Fixes #213

balamurugana · 2018-05-31T23:35:11Z

Dockerfile

@@ -10,6 +10,10 @@ ENV GOPATH /usr/local

 ENV PATH $GOPATH/bin:$GOROOT/bin:$PATH

+COPY dnsmasq.conf /etc/dnsmasq.conf


This is not required.

balamurugana · 2018-05-31T23:35:50Z

Dockerfile

@@ -10,6 +10,10 @@ ENV GOPATH /usr/local

 ENV PATH $GOPATH/bin:$GOROOT/bin:$PATH

+COPY dnsmasq.conf /etc/dnsmasq.conf
+
+EXPOSE 53/udp


As we are running name server locally, I don't think this is required.

balamurugana · 2018-05-31T23:36:10Z

Dockerfile.dev

@@ -12,7 +12,9 @@ ENV PATH $GOPATH/bin:$GOROOT/bin:$PATH

 WORKDIR /mint

-RUN apt-get --yes update && apt-get --yes upgrade && apt-get --yes --quiet install wget jq curl
+EXPOSE 53/udp


same as above

balamurugana · 2018-05-31T23:36:42Z

README.md

@@ -37,11 +37,34 @@ Below environment variables are required to be passed to the docker container. S

 | Environment variable | Description | Example |
 |:--- |:--- |:--- |
-| `SERVER_ENDPOINT` | Endpoint of Minio server in the format `HOST:PORT` | `play.minio.io:9000` |
+| `SERVER_ENDPOINT` | Endpoint of Minio server in the format `HOST:PORT` | `192.168.86.133:9000` |
+| `DOMAIN` | Domain name of the server | `minio.com` |


This is optional. Only required when virtual style is used.

balamurugana · 2018-05-31T23:37:37Z

README.md

@@ -37,11 +37,34 @@ Below environment variables are required to be passed to the docker container. S

 | Environment variable | Description | Example |
 |:--- |:--- |:--- |
-| `SERVER_ENDPOINT` | Endpoint of Minio server in the format `HOST:PORT` | `play.minio.io:9000` |
+| `SERVER_ENDPOINT` | Endpoint of Minio server in the format `HOST:PORT` | `192.168.86.133:9000` |


IP address is used only if virtual style is used. Otherwise its OK to have name like play.minio.io.

balamurugana · 2018-05-31T23:40:18Z

README.md

+
+- Set a domain in your Minio server using environment variable MINIO_DOMAIN. For example `export MINIO_DOMAIN=minio.com`.
+- Start Minio server.
+- For testing Minio server via domain `minio.com` or sub-domain name like `bucket-name.minio.com`, the domain should be resolvable from Mint container via `dnsmasq`. Mint uses the domain name provided in `DOMAIN` for testing purposes. And will be resolved to the host ip in the `SERVER_ENDPOINT`. 


This step (explanation) is not required. If you want to keep it documented, move above as description.

balamurugana · 2018-05-31T23:42:21Z

README.md

+- Set a domain in your Minio server using environment variable MINIO_DOMAIN. For example `export MINIO_DOMAIN=minio.com`.
+- Start Minio server.
+- For testing Minio server via domain `minio.com` or sub-domain name like `bucket-name.minio.com`, the domain should be resolvable from Mint container via `dnsmasq`. Mint uses the domain name provided in `DOMAIN` for testing purposes. And will be resolved to the host ip in the `SERVER_ENDPOINT`. 
+- You can execute Mint against Minio server (with `MINIO_DOMAIN` set to `minio.com`) using this command,


You would need to add MINIO_DOMAIN, ENABLE_VIRTUAL_STYLE and keep SERVER_ENDPOINT contains IP:PORT

balamurugana · 2018-05-31T23:43:11Z

run/core/awscli/run.sh

-# run tests
-endpoint="http://$SERVER_ENDPOINT"
+SERVER_IP=`echo "${SERVER_ENDPOINT%%:*}"`
+SERVER_PORT=`echo "${SERVER_ENDPOINT/*:/}"`


No need to have echo. Similarly these info is required only when ENABLE_VIRTUAL_STYLE is on.

You would need to validate whether SERVER_IP is really an IPv4 address or not. If not you would need to error out and fail. So this needs to be in mint.sh

balamurugana · 2018-05-31T23:45:10Z

run/core/awscli/run.sh

 if [ "$ENABLE_HTTPS" -eq 1 ]; then
-    endpoint="https://$SERVER_ENDPOINT"
+    endpoint="https://$DOMAIN:$SERVER_PORT"


you don't need to change endpoint i.e. this is correct for path style.

balamurugana · 2018-05-31T23:52:32Z

run/core/awscli/run.sh

+# check the access style and run tests if virtual style is set
+if [ "$ENABLE_VIRTUAL_STYLE" -eq 1 ]; then
+    dnsmasq --address=/$DOMAIN/$SERVER_IP --user=root
+    echo -e "nameserver 127.0.0.1\n$(cat /etc/resolv.conf)" > /etc/resolv.conf


below code is much better than echo style.

cat - /etc/resolv.conf > /etc/resolv.conf <<EOF nameserver 127.0.0.1 EOF

Praveenrajmani · 2018-06-02T03:39:22Z

@nitisht @balamurugana Changes updated.

balamurugana · 2018-06-02T04:13:34Z

README.md

@@ -37,11 +37,35 @@ Below environment variables are required to be passed to the docker container. S

 | Environment variable | Description | Example |
 |:--- |:--- |:--- |
-| `SERVER_ENDPOINT` | Endpoint of Minio server in the format `HOST:PORT` | `play.minio.io:9000` |
+| `SERVER_ENDPOINT` | Endpoint of Minio server in the format `HOST:PORT`. Should be `IP:PORT` for virtual-style tests | `play.minio.io:900` |


Below text is better
Endpoint of Minio server in the format HOST:PORT; for virtual style IP:PORT

Fix the example; play.minio.io:9000

balamurugana · 2018-06-02T04:18:45Z

README.md

@@ -37,11 +37,35 @@ Below environment variables are required to be passed to the docker container. S

 | Environment variable | Description | Example |
 |:--- |:--- |:--- |
-| `SERVER_ENDPOINT` | Endpoint of Minio server in the format `HOST:PORT` | `play.minio.io:9000` |
+| `SERVER_ENDPOINT` | Endpoint of Minio server in the format `HOST:PORT`. Should be `IP:PORT` for virtual-style tests | `play.minio.io:900` |
+| `DOMAIN` | (OPTIONAL) (Required for virtual-style tests) Domain name of the server | `minio.com` |


Below text is better
Value of MINIO_DOMAIN environment variable used in Minio server

Use better example'; myminio.com

balamurugana · 2018-06-02T04:19:59Z

README.md

 | `ACCESS_KEY` | Access key of access `SERVER_ENDPOINT` | `Q3AM3UQ867SPQQA43P2F` |
 | `SECRET_KEY` | Secret Key of access `SERVER_ENDPOINT` | `zuf+tfteSlswRu7BJ86wekitnifILbZam1KYY3TG` |
 | `ENABLE_HTTPS` | (Optional) Set `1` to indicate to use HTTPS to access `SERVER_ENDPOINT`. Defaults to `0` (HTTP) | `1` |
 | `MINT_MODE` | (Optional) Set mode indicating what category of tests to be run by values `core` or `full`.  Defaults to `core` | `full` |
+| `ENABLE_VIRTUAL_STYLE` | (Optional) Set `1` to enable virtual style access to `SERVER_ENDPOINT`. Defaults to `0` (Path style) | `1` |


Set 1 to indicate to use virtual style access ...

balamurugana · 2018-06-02T04:20:31Z

README.md

+
+### Test virtual style access against Minio server
+
+For testing Minio server via domain `minio.com` or sub-domain name like `bucket-name.minio.com`, the domain should be resolvable from Mint container via `dnsmasq`. Mint uses the domain name provided in `DOMAIN` for testing purposes. And will be resolved to the host ip in the `SERVER_ENDPOINT`.


I don't think this text is helpful for mint users. We could remove

balamurugana · 2018-06-02T04:22:21Z

README.md

+
+To test Minio server virtual style access with Mint, follow these steps:
+
+- Set a domain in your Minio server using environment variable MINIO_DOMAIN. For example `export MINIO_DOMAIN=minio.com`.


Change minio.com into myminio.com

balamurugana · 2018-06-02T04:22:59Z

README.md

+
+
+```sh
+$ docker run -e "SERVER_ENDPOINT=192.168.86.133:9000" \


Format this command as same as in other places.

balamurugana · 2018-06-02T04:23:25Z

README.md

+-e "ACCESS_KEY=minio" \
+-e "SECRET_KEY=minio123" \
+-e "ENABLE_HTTPS=0" \
+-e "ENABLE_VIRTUAL_STYLE=1" minio/mint awscli


no need to specify awscli

balamurugana · 2018-06-02T04:25:21Z

README.md

+
+- Set a domain in your Minio server using environment variable MINIO_DOMAIN. For example `export MINIO_DOMAIN=minio.com`.
+- Start Minio server. 
+- You can execute Mint against Minio server (with `MINIO_DOMAIN` set to `minio.com`) using this command


Use one style like i.e. don't use you can execute

balamurugana · 2018-06-02T04:26:13Z

mint.sh

    export SERVER_REGION
+    export ENABLE_HTTPS


No need to move this line from previous position.

balamurugana · 2018-06-02T04:27:13Z

run/core/awscli/run.sh

-if [ "$ENABLE_HTTPS" -eq 1 ]; then
-    endpoint="https://$SERVER_ENDPOINT"
+
+endpoint="https://$SERVER_ENDPOINT"


You should not remove HTTPS check

balamurugana · 2018-06-02T04:27:29Z

run/core/awscli/run.sh

+
+# check the access style and run tests if virtual style is set
+if [ "$ENABLE_VIRTUAL_STYLE" -eq 1 ]; then
+


remove this blank line

balamurugana · 2018-06-02T04:28:12Z

run/core/awscli/run.sh

+if [ "$ENABLE_VIRTUAL_STYLE" -eq 1 ]; then
+
+   SERVER_IP=${SERVER_ENDPOINT%%:*}
+   SERVER_PORT=${SERVER_ENDPOINT/*:/}


Always use double quotes

balamurugana · 2018-06-02T04:29:30Z

run/core/awscli/run.sh

+   SERVER_PORT=${SERVER_ENDPOINT/*:/}
+
+   # validate the server_ip
+   if [[ $SERVER_IP =~ ^[0-9]+\.[0-9]+\.[0-9]+\.[0-9]+$ ]]; then


This if is not required because you are splitting it by . anyway. My recommendation is to use array than list of strings below.

@balamurugana The condition is used to check whether the ip has four dots . Else it exits with an error

As you split the string by ., you don't need to do the check. Below code is good enough

readarray -td. octets <<< "$SERVER_IP" if [ "${#octets[@]}" -ne 4 ]; then echo "$SERVER_IP must be an IP address" exit 1 fi for octet in "${octets[@]}"; do if [ "$octet" -lt 0 ] 2>/dev/null || [ "$octet" -gt 255 ] 2>/dev/null; then echo "$SERVER_IP must be an IP address" exit 1 fi done

As mentioned that, this check needs to be moved to mint.sh to fail earlier and later enhancement for other tests use virtual style

balamurugana · 2018-06-02T04:30:25Z

run/core/awscli/run.sh

+   # validate the server_ip
+   if [[ $SERVER_IP =~ ^[0-9]+\.[0-9]+\.[0-9]+\.[0-9]+$ ]]; then
+       for OCTET in $(echo "$SERVER_IP" | tr '.' ' '); do
+           if [[ $OCTET -lt 0 || $OCTET -gt 255 ]]; then


do not use OCTET. all caps mean exported/global variable as a convention.

this check should be done in mint.sh so that you fail early.

balamurugana · 2018-06-02T04:32:40Z

run/core/awscli/run.sh

+       endpoint="https://$DOMAIN:$SERVER_PORT"
+   fi
+
+   dnsmasq --address=/"$DOMAIN"/"$SERVER_IP" --user=root


use "/$DOMAIN/$SERVER_IP" this is much cleaner

balamurugana · 2018-06-02T04:34:17Z

run/core/awscli/run.sh

 fi
+
+# run path style tests
+aws configure set default.s3.addressing_style path


move this if block after ./test.sh ... i.e. you are resetting back as you set to virtual style before

so you mean we have to execute path style tests first and then virtual style (only If the flag is set to 1) ?? @balamurugana

I was saying add below code into line#31

if [ "$ENABLE_VIRTUAL_STYLE" -eq 1 ]; then ## setup local DNS server to resolve *.domain.name into IP address dnsmasq --address="/$DOMAIN/$SERVER_IP" --user=root sed -i "1inameserver 127.0.0.1" /etc/resolv.conf endpoint="http://$DOMAIN:$SERVER_PORT" if [ "$ENABLE_HTTPS" -eq 1 ]; then endpoint="https://$DOMAIN:$SERVER_PORT" fi aws configure set default.s3.addressing_style virtual ./test.sh "$endpoint" 1>>"$output_log_file" 2>"$error_log_file" aws configure set default.s3.addressing_style path fi

This way it is completely fused without disturbed existing code flow.

@balamurugana So you mean the addressing_style is path by default ??
If not, the above change will not execute path style tests , As we are setting the styleaws configure set default.s3.addressing_style path only if the virtual flag is set .
If the flag is not set , the addressing style will not be set to path at all .

@balamurugana i think i misunderstood the change request here

Praveenrajmani · 2018-06-05T07:05:51Z

@balamurugana @nitisht The changes are done .

nitisht

LGTM overall, few doc changes

nitisht · 2018-06-05T09:46:51Z

README.md

 | `ACCESS_KEY` | Access key of access `SERVER_ENDPOINT` | `Q3AM3UQ867SPQQA43P2F` |
 | `SECRET_KEY` | Secret Key of access `SERVER_ENDPOINT` | `zuf+tfteSlswRu7BJ86wekitnifILbZam1KYY3TG` |
 | `ENABLE_HTTPS` | (Optional) Set `1` to indicate to use HTTPS to access `SERVER_ENDPOINT`. Defaults to `0` (HTTP) | `1` |
 | `MINT_MODE` | (Optional) Set mode indicating what category of tests to be run by values `core` or `full`.  Defaults to `core` | `full` |
+| `ENABLE_VIRTUAL_STYLE` | (Optional) Set `1` to indicate virtual style access . Defaults to `0` (Path style) | `1` |


you can club the optional flags DOMAIN and ENABLE_VIRTUAL_STYLE together at the last. Also don't use default values for optional fields and use optional (instead of OPTIONAL or Optional)

nitisht · 2018-06-05T09:48:46Z

README.md

+- Start Minio server. 
+- Execute Mint against Minio server (with `MINIO_DOMAIN` set to `myminio.com`) using this command
+
+


remove extra line

balamurugana · 2018-06-05T10:02:33Z

mint.sh

+        SERVER_IP="${SERVER_ENDPOINT%%:*}"
+        SERVER_PORT="${SERVER_ENDPOINT/*:/}"
+        # validate the server_ip
+        octets=(${SERVER_IP//./ })


Use quotes here "${SERVER_IP//./ }"

balamurugana · 2018-06-05T10:03:24Z

mint.sh

    echo

    echo "To get logs, run 'docker cp ${CONTAINER_ID}:/mint/log /tmp/mint-logs'"
-
+  


remove extra whitespaces

balamurugana · 2018-06-05T10:04:47Z

README.md

@@ -37,12 +37,34 @@ Below environment variables are required to be passed to the docker container. S

 | Environment variable | Description | Example |
 |:--- |:--- |:--- |
-| `SERVER_ENDPOINT` | Endpoint of Minio server in the format `HOST:PORT` | `play.minio.io:9000` |
+| `SERVER_ENDPOINT` | Endpoint of Minio server in the format `HOST:PORT`; for virtual style `IP:PORT` | `play.minio.io:900` |
+| `DOMAIN` | (OPTIONAL) (Required for virtual-style tests) Value of MINIO_DOMAIN environment variable used in Minio server | `myminio.com` |


Make Optional and remove (Required ...) which is conflicting with optional

balamurugana · 2018-06-05T10:06:46Z

run/core/awscli/run.sh

@@ -29,9 +29,25 @@ aws configure set aws_access_key_id "$ACCESS_KEY"
 aws configure set aws_secret_access_key "$SECRET_KEY"
 aws configure set default.region "$SERVER_REGION"

-# run tests
+


Remove this empty line

balamurugana · 2018-06-05T10:07:48Z

run/core/awscli/run.sh

 endpoint="http://$SERVER_ENDPOINT"
 if [ "$ENABLE_HTTPS" -eq 1 ]; then
    endpoint="https://$SERVER_ENDPOINT"
 fi
+
+# check the access style and run tests if virtual style is set


# run tests for virtual style if provided is good enough

Also move this block above endpoint declaration so that its cleanly patched

Praveenrajmani · 2018-06-05T18:38:14Z

@balamurugana @nitisht the changes are done

balamurugana · 2018-06-06T00:56:38Z

README.md

@@ -37,12 +37,33 @@ Below environment variables are required to be passed to the docker container. S

 | Environment variable | Description | Example |
 |:--- |:--- |:--- |
-| `SERVER_ENDPOINT` | Endpoint of Minio server in the format `HOST:PORT` | `play.minio.io:9000` |
+| `SERVER_ENDPOINT` | Endpoint of Minio server in the format `HOST:PORT`; for virtual style `IP:PORT` | `play.minio.io:900` |


port is 9000

balamurugana · 2018-06-06T00:57:53Z

README.md

+| `ENABLE_HTTPS` | (optional) Set `1` to indicate to use HTTPS to access `SERVER_ENDPOINT`. Defaults to `0` (HTTP) | `1` |
+| `MINT_MODE` | (optional) Set mode indicating what category of tests to be run by values `core` or `full`.  Defaults to `core` | `full` |
+| `DOMAIN` | (optional) Value of MINIO_DOMAIN environment variable used in Minio server | `myminio.com` |
+| `ENABLE_VIRTUAL_STYLE` | (optional) Set `1` to indicate virtual style access . Defaults to `0` (Path style) | `1` |


Not sure why change Optional to optional. I specifically added it for readability.

balamurugana · 2018-06-06T00:58:10Z

README.md

+	     -e "ACCESS_KEY=minio" \
+	     -e "SECRET_KEY=minio123" \
+	     -e "ENABLE_HTTPS=0" \
+	     -e "ENABLE_VIRTUAL_STYLE=1" minio/mint		


Fix formatting

balamurugana · 2018-06-06T00:58:25Z

README.md

+- Start Minio server. 
+- Execute Mint against Minio server (with `MINIO_DOMAIN` set to `myminio.com`) using this command
+```sh
+


Remove this empty line

balamurugana · 2018-06-06T01:00:08Z

README.md

+	     -e "ENABLE_VIRTUAL_STYLE=1" minio/mint		
+```
+
+We set the `ENABLE_VIRTUAL_STYLE` flag to `1` to indicate that virtual style tests be run.


As the section/information is provided already, this text is not required.

balamurugana · 2018-06-06T01:01:26Z

mint.sh

+if [ "$ENABLE_VIRTUAL_STYLE" -eq 1 ]; then
+        SERVER_IP="${SERVER_ENDPOINT%%:*}"
+        SERVER_PORT="${SERVER_ENDPOINT/*:/}"
+        # validate the server_ip


Check if SERVER_IP is actually IPv4 address

@balamurugana we are already checking that right ?

I meant the comment is wrong # validate the server_ip

This will now facilitate the randomized wildcard bucket names in awscli tests (virtual style paths). Fixes #213

Praveenrajmani · 2018-06-26T12:36:35Z

@balamurugana The changes are done. Please check

balamurugana · 2018-06-26T14:44:52Z

LGTM. Please resolve conflicts.

nitisht

LGTM

Amirreza1396 · 2023-03-18T00:51:18Z

The dnsmasq will now accept wildcard bucket name entries.

The container is spawned by

docker run -e "SERVER_ENDPOINT=192.168.86.133:9000" \ -e "DOMAIN=minio.com" -e "ACCESS_KEY=minio" \ -e "SECRET_KEY=**REDACTED**" -e "ENABLE_HTTPS=0" \ -e "ENABLE_VIRTUAL_STYLE=1" minio/mint awscli

The DOMAIN provided in the env will be resolved to the host ip in SERVER_ENDPOINT

Fixes: #213

nitisht and others added 2 commits November 20, 2017 09:50

Add new mode to test virtual host style with awscli

72c04d2

Mint awscli tests now run against both path style and virtual style if virtual style flag is set. By default only path style tests are run Fixes #213

merged conflicts

c7eede9

kannappanr requested a review from nitisht May 31, 2018 20:54

kannappanr assigned balamurugana and unassigned balamurugana May 31, 2018

kannappanr requested a review from balamurugana May 31, 2018 20:54

balamurugana requested changes May 31, 2018

View reviewed changes

balamurugana reviewed Jun 2, 2018

View reviewed changes

README.md Outdated

```sh

$ docker run -e "SERVER_ENDPOINT=192.168.86.133:9000" \

Copy link

Member

balamurugana Jun 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Format this command as same as in other places.

balamurugana reviewed Jun 2, 2018

View reviewed changes

mint.sh Outdated

export SERVER_REGION

export ENABLE_HTTPS

Copy link

Member

balamurugana Jun 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to move this line from previous position.

balamurugana reviewed Jun 2, 2018

View reviewed changes

nitisht reviewed Jun 5, 2018

View reviewed changes

balamurugana reviewed Jun 5, 2018

View reviewed changes

mint.sh Outdated

echo

echo "To get logs, run 'docker cp ${CONTAINER_ID}:/mint/log /tmp/mint-logs'"

Copy link

Member

balamurugana Jun 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove extra whitespaces

balamurugana reviewed Jun 5, 2018

View reviewed changes

balamurugana reviewed Jun 6, 2018

View reviewed changes

The dnsmasq will now resolve the wildcard entries also

0187059

This will now facilitate the randomized wildcard bucket names in awscli tests (virtual style paths). Fixes #213

Merge branch 'master' into dnsmasqFix

ac56056

nitisht approved these changes Jun 27, 2018

View reviewed changes

balamurugana approved these changes Jun 28, 2018

View reviewed changes

harshavardhana merged commit 37a6cd8 into minio:master Jun 28, 2018

		@@ -10,6 +10,10 @@ ENV GOPATH /usr/local

		ENV PATH $GOPATH/bin:$GOROOT/bin:$PATH

		COPY dnsmasq.conf /etc/dnsmasq.conf


		### Test virtual style access against Minio server

		For testing Minio server via domain `minio.com` or sub-domain name like `bucket-name.minio.com`, the domain should be resolvable from Mint container via `dnsmasq`. Mint uses the domain name provided in `DOMAIN` for testing purposes. And will be resolved to the host ip in the `SERVER_ENDPOINT`.


		To test Minio server virtual style access with Mint, follow these steps:

		- Set a domain in your Minio server using environment variable MINIO_DOMAIN. For example `export MINIO_DOMAIN=minio.com`.



		```sh
		$ docker run -e "SERVER_ENDPOINT=192.168.86.133:9000" \


		# check the access style and run tests if virtual style is set
		if [ "$ENABLE_VIRTUAL_STYLE" -eq 1 ]; then

		- Start Minio server.
		- Execute Mint against Minio server (with `MINIO_DOMAIN` set to `myminio.com`) using this command

		echo

		echo "To get logs, run 'docker cp ${CONTAINER_ID}:/mint/log /tmp/mint-logs'"

The awscli tests for virtual style paths (dnsmasq fix) #278

The awscli tests for virtual style paths (dnsmasq fix) #278

Conversation

Praveenrajmani commented May 31, 2018 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Praveenrajmani commented Jun 2, 2018

balamurugana Jun 2, 2018 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

balamurugana Jun 2, 2018 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

balamurugana Jun 3, 2018 • edited

Choose a reason for hiding this comment

balamurugana Jun 2, 2018 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Praveenrajmani Jun 2, 2018 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Praveenrajmani commented Jun 5, 2018

nitisht left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

balamurugana Jun 5, 2018 • edited

Choose a reason for hiding this comment

Praveenrajmani commented Jun 5, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Praveenrajmani commented Jun 26, 2018

balamurugana commented Jun 26, 2018

nitisht left a comment

Choose a reason for hiding this comment

Amirreza1396 commented Mar 18, 2023

Praveenrajmani commented May 31, 2018 •

edited

balamurugana Jun 2, 2018 •

edited

balamurugana Jun 2, 2018 •

edited

balamurugana Jun 3, 2018 •

edited

balamurugana Jun 2, 2018 •

edited

Praveenrajmani Jun 2, 2018 •

edited

balamurugana Jun 5, 2018 •

edited