Use smaller upload files for mint #41
Conversation
|
can you remove the binary files from the commit? also move |
run/core/minio-go/run.sh
Outdated
| @@ -16,7 +16,7 @@ | |||
| # | |||
|
|
|||
| run() { | |||
| ./minio.test && ./minio.test -test.v -test.timeout 20m | |||
| ./minio.go | |||
There was a problem hiding this comment.
buildMinioGoTests() will build this binary in go-deps.sh
There was a problem hiding this comment.
But why extension minio.go ? we should avoid naming it like a source file. Name it as minio-go or minio-go-test
| @@ -39,7 +39,9 @@ buildInitTests() { | |||
|
|
|||
| # Build Minio Go tests | |||
| buildMinioGoTests() { | |||
| go test -o ${minio_go_sdk_path}/minio.test -c ${minio_go_sdk_path}/api_functional_v4_test.go | |||
| go get -u github.com/sirupsen/logrus && \ | |||
There was a problem hiding this comment.
Tabbing issue. please use a better editor.
buildscripts/initData.sh
Outdated
| mkdir $data_dir | ||
| fi | ||
| cd $data_dir | ||
| dd if=/dev/zero of=SmallFile bs=1024 count=10 |
There was a problem hiding this comment.
Create a loop for this.. by combining common bs= values. Also use bs=1M instead of 1024 writing 1k blocks to disk is inefficient.
|
If there is nothing pending, can you pls approve it @harshavardhana |
|
@poornas can you pls update the README.md with the data_dir file details, i.e. For each file, just add these two details.
This will be helpful for others adding tests cases in different SDKs |
| @@ -0,0 +1,31 @@ | |||
| #!/bin/bash | |||
| # | |||
| # Minio Cloud Storage, (C) 2017 Minio, Inc. | |||
There was a problem hiding this comment.
The license header should say Mint instead of Minio Cloud Storage. You could fix this in a separate PR for all files.
Changed SDK tests to use data files from a common directory that is generated at the time of docker image build. Using smaller files to speed up execution of tests