Add awscli preliminary tests and refactor python language. #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshavardhana
force-pushed
the
cleanup-add-aws-cli
branch
3 times, most recently
from
cc8cdb7
to
5fce0b9
Compare
harshavardhana
changed the title
harshavardhana
force-pushed
the
cleanup-add-aws-cli
branch
from
5fce0b9
to
a5cfbef
Compare
nitisht
reviewed
Jun 27, 2017
buildscripts/py/minio-py.sh
Outdated
|
|
||
| cleanDeps() { | ||
| # Nothing yet. | ||
| echo |
There was a problem hiding this comment.
can we remove pip while cleanup?
There was a problem hiding this comment.
Not here we remove in install.sh
nitisht
reviewed
Jun 27, 2017
buildscripts/py/aws-cli.sh
Outdated
| apt-get autoremove -yq | ||
| cleanDeps() { | ||
| # Nothing yet. | ||
| echo | ||
| } |
There was a problem hiding this comment.
can remove cleanDeps() if not required here.
nitisht
approved these changes
Jun 28, 2017
|
Can you pls take a look @poornas |
poornas
reviewed
Jun 28, 2017
run.sh
Outdated
|
|
||
| do | ||
| for i in ${root_dir}/${test_dir}/*; | ||
|
|
There was a problem hiding this comment.
whitespace unnecessary here
There was a problem hiding this comment.
run.sh
Outdated
| if [ -d ${i} ]; then | ||
|
|
||
| # Will not run if no directories are available | ||
| sdk="$(basename $i)" | ||
| echo "Running $sdk tests ..." | ||
|
|
run/core/minio-java/run.sh
Outdated
| @@ -1,4 +1,4 @@ | |||
| #!/usr/bin/env bash | |||
| #!/bin/bash | |||
| # | |||
| # Minio Cloud Storage, (C) 2017 Minio, Inc. | |||
poornas
requested changes
Jun 28, 2017
harshavardhana
force-pushed
the
cleanup-add-aws-cli
branch
from
a5cfbef
to
7aa7640
Compare
Fixed @poornas |
harshavardhana
force-pushed
the
cleanup-add-aws-cli
branch
from
7aa7640
to
453d7d6
Compare
- This PR only changes python, so that other languages can follow. Adds a new package `awscli` for `awscli` tests. - Adds awscli preliminary tests Refer minio#44
harshavardhana
force-pushed
the
cleanup-add-aws-cli
branch
from
453d7d6
to
62c8074
Compare
poornas
approved these changes
Jun 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR only changes python, so that other languages
can follow. Adds a new package
awscliforawsclitests.Adds awscli preliminary tests
Refer #44