Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all languages into their relevant dir. #47

Merged
merged 1 commit into from
Jun 28, 2017

Conversation

harshavardhana
Copy link
Member

Consolidate scripts and bring a sort of
framework. To install new packages by
just dropping in a script inside these relevant
directories.

@harshavardhana
Copy link
Member Author

Testing in progress, reviews welcome!

Copy link
Member

@krisis krisis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it makes sense to keep all scripts for a language/tool in one place.

Haven't tested it locally.

@harshavardhana harshavardhana force-pushed the move-java branch 2 times, most recently from bc43a59 to a2d5965 Compare June 28, 2017 07:49
Copy link
Contributor

@nitisht nitisht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harshavardhana harshavardhana force-pushed the move-java branch 4 times, most recently from 67908b4 to f777f77 Compare June 28, 2017 17:32
Consolidate scripts and bring a sort of
framework. To install new packages by
just dropping in a script inside these relevant
directories.
@deekoder deekoder merged commit debe8f5 into minio:master Jun 28, 2017
@harshavardhana harshavardhana deleted the move-java branch June 28, 2017 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants