Framework updates #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nitisht
commented
Jun 29, 2017
nitisht
commented
- Add time tracker
- Remove init tests
- Add ENV var to ignore tests
- Update dockerfile
- Add time tracker - Remove init tests - Add ENV var to ignore tests
harshavardhana
requested changes
Jun 29, 2017
README.md
Outdated
| - `SECRET_KEY` - Secret Key of the server. Defaults to Minio Play Secret Key. | ||
| - `ENABLE_HTTPS` - Set to 1 to send HTTPS requests on SSL enabled deployment. Defaults to 0. | ||
| - `DATA_DIR` - Data directory for SDK tests. Defaults to data directory created by `build/data/install.sh` script. | ||
| - `IGNORE_TESTS` - `;` separated list of SDKs to ignore running. Empty by default. |
There was a problem hiding this comment.
Comma is easier type than ;
There was a problem hiding this comment.
BTW there are unexpected commits in this PR can you clean it up and squash them?
nitisht
force-pushed
the
framework-updates
branch
from
8d15a66
to
0fb0dcc
Compare
poornas
requested changes
Jun 29, 2017
run.sh
Outdated
| # move back to top level directory | ||
| cd ../../.. | ||
| # move back to top level directory | ||
| cd ../../.. |
There was a problem hiding this comment.
instead of cd ../../.., it would be better to use cd $root_dir
README.md
Outdated
| - `SECRET_KEY` - Secret Key of the server. Defaults to Minio Play Secret Key. | ||
| - `ENABLE_HTTPS` - Set to 1 to send HTTPS requests on SSL enabled deployment. Defaults to 0. | ||
| - `DATA_DIR` - Data directory for SDK tests. Defaults to data directory created by `build/data/install.sh` script. | ||
| - `IGNORE_TESTS` - `,` separated list of SDKs to ignore running. Empty by default. |
There was a problem hiding this comment.
s/, separated list of SDKs to ignore running./',' separated list of SDKs to skip running.
IGNORE_TESTS could optionally be better named as SKIP_TESTS
An example with this option would be useful as it is not clear here that the sdk naming convention of data directory needs to be followed in the IGNORE_TESTS
nitisht
force-pushed
the
framework-updates
branch
from
0fb0dcc
to
d679bae
Compare
|
Updated @poornas @harshavardhana |
poornas
approved these changes
Jun 29, 2017
harshavardhana
approved these changes
Jun 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.