Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop tests and exit in case of TERM or INT signals #55

Merged
merged 1 commit into from
Jun 30, 2017
Merged

Stop tests and exit in case of TERM or INT signals #55

merged 1 commit into from
Jun 30, 2017

Conversation

vadmeste
Copy link
Member

  • run.sh is renamed to tests.sh
  • run.sh becomes a generic script to run an app which a possibility of
    killing after a keyboard interruption

@vadmeste
Stop tests and exit in case of TERM or INT signals
c5b6cac 
* run.sh is renamed to tests.sh
* run.sh becomes a generic script to run an app which a possibility of
killing after a keyboard interruption
@nitisht nitisht self-requested a review June 30, 2017 01:11
nitisht
nitisht approved these changes Jun 30, 2017
View reviewed changes
Copy link
Contributor

@nitisht nitisht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM

@nitisht nitisht merged commit b54eac0 into minio:master Jun 30, 2017
@nitisht
Copy link
Contributor

nitisht commented Jun 30, 2017

@vadmeste I observed that even after the tests are done, container doesn't exit. It just waits until manual ^c . It should exit on completion or first failure.

Use 'docker ps -a' to find container-id
Export run logs from the container using 'docker cp container-id:/mint/log /tmp/mint-logs'

^CEXIT signal captured..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshavardhana harshavardhana harshavardhana approved these changes

@nitisht nitisht nitisht approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vadmeste @nitisht @harshavardhana