Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix formatting and add humanized duration. #56

Merged
merged 1 commit into from
Jun 30, 2017
Merged

Fix formatting and add humanized duration. #56

merged 1 commit into from
Jun 30, 2017

Conversation

harshavardhana
Copy link
Member

@harshavardhana harshavardhana commented Jun 30, 2017 •
edited
Loading

No description provided.

@harshavardhana harshavardhana force-pushed the fix-tests branch 2 times, most recently from 7d6d98d to 40bcf87 Compare June 30, 2017 07:53
@harshavardhana harshavardhana changed the title Fix tests and simplify skipping tests. Fix formatting and add humanized duration. Jun 30, 2017
@nitisht nitisht requested review from vadmeste and nitisht June 30, 2017 19:23
nitisht
nitisht approved these changes Jun 30, 2017
View reviewed changes
Copy link
Contributor

@nitisht nitisht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM

vadmeste
vadmeste reviewed Jun 30, 2017
View reviewed changes
tests.sh Outdated

# move back to top level directory
cd "${root_dir}"
}

# checks if an elements is not present in an array
Copy link
Member

@vadmeste vadmeste Jun 30, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/elements/element

vadmeste
vadmeste approved these changes Jun 30, 2017
View reviewed changes
Copy link
Member

@vadmeste vadmeste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only one minor comment

@nitisht nitisht merged commit ecc251e into minio:master Jun 30, 2017
@harshavardhana harshavardhana deleted the fix-tests branch June 30, 2017 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vadmeste vadmeste vadmeste approved these changes

@nitisht nitisht nitisht approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@harshavardhana @vadmeste @nitisht