Add copyObject, presignedObject for awscli #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any reviews here ? |
nitisht
suggested changes
Jul 1, 2017
run/core/awscli/test.sh
Outdated
| ${AWS} s3api delete-bucket --bucket "${bucketName}" | ||
| } | ||
|
|
||
| copy_07() { |
There was a problem hiding this comment.
could you elaborate the test name or add a comment to clarify the test case. I mean copy is not clear here.
There was a problem hiding this comment.
It just means aws s3 cp let me comment them properly.
run/core/awscli/test.sh
Outdated
| @@ -201,7 +269,7 @@ copy_05() { | |||
| ${AWS} s3 rb "s3://${bucketName}/" | |||
| } | |||
|
|
|||
| sync_06() { | |||
| sync_08() { | |||
|
@nitisht updated with more comments on each tests. |
nitisht
approved these changes
Jul 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #44