Fix minio-go tests as per the latest changes in minio-go library. #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nitisht
force-pushed
the
minio-go-test-fix
branch
from
401801e
to
251c656
Compare
harshavardhana
requested changes
Jul 3, 2017
run/core/minio-go/minio-go-tests.go
Outdated
| "fmt" | ||
| "io" | ||
| "io/ioutil" | ||
| "math/rand" |
There was a problem hiding this comment.
This formatting is all off
$ gofmt -s -d minio-go-tests.go
- testBucketNotification()
- testFunctional()
- testGetObjectObjectModified()
- testPutObjectUploadSeekedObject()
- testComposeMultipleSources()
- testComposeObjectErrorCases()
- log.Info("Functional tests complete for minio-go sdk")
+ log.Info("Running functional tests for minio-go sdk....")
+ testMakeBucketError()
+ testMakeBucketRegions()
+ testPutObjectWithMetadata()
+
+ testPutObjectReadAt()
+
+ testPutObjectStreaming()
+ testListPartiallyUploaded()
+ testGetObjectSeekEnd()
+ testGetObjectClosedTwice()
+ testRemoveMultipleObjects()
+ testRemovePartiallyUploaded()
+ testFPutObjectMultipart()
+ testFPutObject()
+ testGetObjectReadSeekFunctional()
+ testGetObjectReadAtFunctional()
+ testPresignedPostPolicy()
+ testCopyObject()
+ testEncryptionPutGet()
+ testBucketNotification()
+ testFunctional()
+ testGetObjectObjectModified()
+ testPutObjectUploadSeekedObject()
+ testComposeMultipleSources()
+ testComposeObjectErrorCases()
+ log.Info("Functional tests complete for minio-go sdk")
}
harshavardhana
requested changes
Jul 3, 2017
There was a problem hiding this comment.
commit 251c6567df9aab706528889f81ab85ee6da99051
Author: Nitish Tiwar <nitish@minio.io>
Date: Sun Jul 2 22:24:13 2017 -0700
Fix minio-go tests as per the latest changes in minio-go library.
- Minio-go introduced new api and changed copy objects api (https://github.com/minio/minio-go/commit/129fe893b2ac95d322d531b7029981f71c351e53).
This broke mint tests.
Commit message shouldn't be wrapped around in this manner - avoid bullets if only one element.
nitisht
force-pushed
the
minio-go-test-fix
branch
from
251c656
to
4771f19
Compare
|
Amended the previous commit. @harshavardhana |
harshavardhana
requested changes
Jul 3, 2017
run/core/minio-go/minio-go-tests.go
Outdated
| // Copy source. | ||
| copySource := bucketName + "/" + objectName | ||
| dst, err := minio.NewDestinationInfo(bucketName+"-copy", objectName+"-copy", nil, nil) | ||
| if err != nil { |
There was a problem hiding this comment.
Tabbing error here.. dst and if are off by one space.
run/core/minio-go/minio-go-tests.go
Outdated
| @@ -2418,6 +2420,132 @@ func logTrace() { | |||
| log.Info(fmt.Sprintf("Running %s at line:%d", f.Name(), line)) | |||
| } | |||
|
|
|||
| func testComposeObjectErrorCases() { | |||
|
|
|||
| // Instantiate new minio client object. | |||
There was a problem hiding this comment.
This comment is off just run gofmt -s -w -l on the file it should fix itself properly.
harshavardhana
approved these changes
Jul 3, 2017
|
@krisis could you pls take a look. |
krisis
approved these changes
Jul 3, 2017
There was a problem hiding this comment.
LGTM. To simplify testing while reviewing PR, we can make automated docker image builds for mint for each PR. E.g mesosphere/universe repo builds docker image for each PR (re)submission - https://hub.docker.com/r/mesosphere/universe-server/tags/.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minio-go introduced new api and changed copy objects api (minio/minio-go@129fe89).
This broke mint tests. The PR updates mint minio-go tests as per minio-go SDK.
Note:
Once minio/minio-go#727 is merged. Mint will be updated to pull tests from minio-go SDK and we'll not maintain multiple copies of the minio-go SDK tests.