Revamping the design. #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
hackintoshrao
commented
Mar 10, 2017
hackintoshrao
commented
- Categorizing tests across different folders based on their functionality.
- Adding root level run.sh to conditionally set env and help select which tests to run (Since Dockerfile cannot have conditional check this is necessary)
- Adding main.go which performs initial on whether Minio server is reachable and supplied credentials are right using admin API.
- Tests run on play by default.
- Load tests and debug tests will be the next category of tests with more test added in sdk-tests.
added 7 commits
March 8, 2017 13:08
- Adding root run.sh and build.sh - run.sh runs all the tests, since Dockerfile doesnt conditional checks for options and env variables those checks are done in run.sh and relevant tests are run - main.go contain checks to see whether Minio server with given credentials are reachable. - By default with no env set the tests are run on play
- Add more comments. - Update Readme.md with more instructions.
- Add run instructions for functional test.
- Add `sync` command to avoid moby/moby#9547 - Fix path in build.sh
- Add functions in run.sh to execute different tests.
- Add functions in run.sh to execute different tests.
harshavardhana
requested changes
Mar 10, 2017
functional-test/README.md
Outdated
| @@ -0,0 +1,17 @@ | |||
| # Functional tests. | |||
| Collection of tests with handcrafted http requests. | |||
|
|
|||
| @@ -0,0 +1,36 @@ | |||
| package main | |||
main.go
Outdated
| package main | ||
|
|
||
| import ( | ||
| "github.com/minio/minio/pkg/madmin" |
There was a problem hiding this comment.
stdlib should proceed the imports
import {
"log"
"os"
"github.com/minio/minio/pkg/madmin"
}
| @@ -0,0 +1,7 @@ | |||
| #!/bin/sh | |||
| @@ -0,0 +1,70 @@ | |||
| #!/bin/sh | |||
run.sh
Outdated
|
|
||
| # Fail if any of the commands exit with a non zero status. | ||
| # Halt the further execution of the script if any of the programs fail. | ||
| set -e |
There was a problem hiding this comment.
Add new line after this for readability..
|
|
||
| # Current tests | ||
| - Minio-go functional test. | ||
|
|
| # This is to avoid https://github.com/docker/docker/issues/9547 | ||
| sync | ||
| # run build | ||
| ./build.sh |
There was a problem hiding this comment.
was it decided to build during the run? each time?
There was a problem hiding this comment.
Since there will be no complex builds in the root on the project, we can just do go run main.go here. But it was decided that each test category folder iwll have a build.sh and run.sh .
- Adding Licences. - Removing extra new lines. - fix import order in main.go
harshavardhana
approved these changes
Mar 10, 2017
| /* | ||
| * Minio Cloud Storage, (C) 2017 Minio, Inc. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); |
There was a problem hiding this comment.
Did you even run this locally? - this will fail to run the script. @hackintoshrao
There was a problem hiding this comment.
It works from the docker container. The path is relatively set to get it to work from the container. On using docker run it works.
There was a problem hiding this comment.
I am talking about the comments @hackintoshrao :P
This was referenced Mar 11, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.