Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mc test cases #71

Merged
merged 2 commits into from
Jul 4, 2017
Merged

Add mc test cases #71

merged 2 commits into from
Jul 4, 2017

Conversation

nitisht
Copy link
Contributor

@nitisht nitisht commented Jul 3, 2017

  • Add mc tests
  • Fix top level script to not remove curl as it is used during test execution.

@nitisht
- Add mc tests
5e84051 
- Fix top level script to not remove curl as it is used during test execution.
poornas
poornas requested changes Jul 3, 2017
View reviewed changes
Copy link
Contributor

@poornas poornas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a lot of code repetition in each test -

run/core/mc/test.sh Outdated

# create a bucket
echo "Creating a bucket"
./mc mb "target/${bucketName}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these make bucket/remove bucket calls are repeated for each test. Consider a helper function to setup the bucket and tear it down. Also function names do not need the numeral suffix - doesn't help in any way. Instead testMirrorObject / testMirrorCommand conveys the functionality being tested.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually @abperiasamy wanted self contained tests.. We shouldn't inherit the problems of other tests. Its harder to debug.

@nitisht
Copy link
Contributor Author

nitisht commented Jul 4, 2017

Updated the tests, please take a look. @harshavardhana @poornas

@nitisht nitisht merged commit 359ff58 into minio:master Jul 4, 2017
@nitisht nitisht deleted the mc-tests branch July 4, 2017 17:19
@nitisht nitisht mentioned this pull request Jul 4, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshavardhana harshavardhana harshavardhana approved these changes

@poornas poornas poornas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nitisht @harshavardhana @poornas