Creates new AWS Ruby SDK api commands and tests #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tabbing looks off @ebozduman . Need to probably run the lint tool |
nitisht
reviewed
Jul 10, 2017
There was a problem hiding this comment.
Tested locally. LGTM
==================================================
*** List Buckets Test
Buckets found:72 - Success!
Making 2 new buckets - Success!
- Success!
Total buckets found now:74 - Success!
Clean-up - Success!
*** PASS
==================================================
*** List Objects Test
Making a bucket - Success!
Files/Objects expected: 3
Files/Objects found: 3 - Success!
Clean-up - Success!
*** PASS
==================================================
*** Make Bucket Test
Making a bucket - Success!
Clean-up - Success!
*** PASS
==================================================
*** Bucket Exists Test
Checking a non-existing bucket - Success!
Clean-up - Success!
*** PASS
==================================================
*** Remove Bucket Test
Making a bucket - Success!
Deleting the bucket - Success!
Clean-up - Success!
*** PASS
==================================================
*** Upload and Remove Object Test
Making a bucket - Success!
Uploading file - Success!
Clean-up - Success!
*** PASS
==================================================
*** Upload and Remove Object Test
Making a bucket - Success!
Uploading file - Success!
Removing file - Success!
Clean-up - Success!
*** PASS
==================================================
*** Download Object Test
Making a bucket - Success!
Uploading file: datafile-1-MB - Success!
Downloading it into destination directory: /tmp - Success!
Clean-up - Success!
*** PASS
==================================================
*** Copy Object Test
Making source bucket: 60d946e08a35 - Success!
Making target bucket: 712ffd892de2 - Success!
Uploading file: datafile-1-MB
... into source bucket: 60d946e08a35 - Success!
Copying file: datafile-1-MB
... from source bucket: 60d946e08a35
... as file: datafile-1-MB
... into target bucket: 712ffd892de2 - Success!
Clean-up - Success!
*** PASS
==================================================
*** Copy Object Test
Making source bucket: 60d946e08a35 - Success!
Making target bucket: 712ffd892de2 - Success!
Uploading file: datafile-1-MB
... into source bucket: 60d946e08a35 - Success!
Copying file: datafile-1-MB
... from source bucket: 60d946e08a35
... as file: datafile-1-MB-copy
... into target bucket: 712ffd892de2 - Success!
Clean-up - Success!
*** PASS
|
any reviews here @harshavardhana |
nitisht
approved these changes
Jul 10, 2017
harshavardhana
requested changes
Jul 11, 2017
| # Add "https://" to "endpoint" if environment | ||
| # variable "ENABLE_HTTPS" is turned on | ||
| # variable "ENABLE_HTTPS" is set to 1 | ||
| endpoint = enable_https == "1" ? 'https://' + endpoint : 'http://' + endpoint |
There was a problem hiding this comment.
isn't it possible to do
endpoint = ENV['ENABLE_HTTPS'] == "1" ? 'https://' + endpoint : 'http://' + endpoint
Is enable_https used anywhere?
There was a problem hiding this comment.
Harsha,
It is already that way in the latest code. Maybe you saw it in the older version of the file.
Could you please recheck it?
harshavardhana
approved these changes
Jul 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Minio Ruby SDK for Amazon S3 is not available yet, I wrote the basic functionality as part of the Mint testing effort. Then created test cases which basically call these commands and check if the expected values are returned.
I took Minio Java SDK for Amazon S3 list of command as a base, and created Ruby SDK commands using the same names.
Here is the list of commands, for which tests created, in this pull request.
Bucket Operations:
Object Operations: