Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup Mint Readme doc #97

Merged
merged 1 commit into from
Jul 20, 2017
Merged

Cleanup Mint Readme doc #97

merged 1 commit into from
Jul 20, 2017

Conversation

nitisht
Copy link
Contributor

@nitisht nitisht commented Jul 17, 2017

No description provided.

@nitisht nitisht requested review from poornas and deekoder July 17, 2017 18:12
deekoder
deekoder suggested changes Jul 17, 2017
View reviewed changes
q Outdated
@@ -0,0 +1,60 @@
diff --git a/README.md b/README.md
index 24af29d..d544c1d 100644
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this file with all the ctrl chars?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was committed erroneously. Removed now @deekoder

poornas
poornas reviewed Jul 17, 2017
View reviewed changes
README.md
@@ -9,7 +9,7 @@ Collection of tests to detect overall correctness of Minio server.

## Roadmap

- Minio-SDK functional tests are pulled from respective SDKs and tested.
- `minio-js`, `minio-go`, `minio-dotnet` functional tests are pulled from respective SDKs instead of local test copy in Mint repo. `minio-py` & `minio-java` tests are already pulled from respective SDKs.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nitisht , doesn't the previous statement express the same without mentioning sdk's by name?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@poornas it was generic, now it is clearer that which of these are done and what is pending.

poornas
poornas requested changes Jul 17, 2017
View reviewed changes
Copy link
Contributor

@poornas poornas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

file q seems to have gotten into commit inadvertently.

@nitisht
Copy link
Contributor Author

nitisht commented Jul 18, 2017

Updated @poornas @deekoder

@deekoder
Copy link
Contributor

I think i clicked on approve for both accidentally. @poornas please can you confirm if you approve.

@poornas
Copy link
Contributor

poornas commented Jul 20, 2017

@deekoder , it is good to go.

@nitisht nitisht merged commit 26e57c9 into minio:master Jul 20, 2017
@nitisht nitisht deleted the update-readme branch July 20, 2017 00:57
nitisht added a commit to nitisht/mint that referenced this pull request Jul 25, 2017
@nitisht
Clean-up readme for Mint (minio#97)
41d0c82
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@poornas poornas poornas approved these changes

@deekoder deekoder deekoder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nitisht @deekoder @poornas