update proper default values 1 sec is too low for liveness (#267)

minio · Aug 26, 2020 · cbd1648 · cbd1648
1 parent 4612151
commit cbd1648
Show file tree

Hide file tree

Showing 10 changed files with 23 additions and 23 deletions.
diff --git a/examples/tenant-console.yaml b/examples/tenant-console.yaml
@@ -37,7 +37,7 @@ spec:
       prometheus.io/port: "9000"
       prometheus.io/scrape: "true"
   ## Registry location and Tag to download MinIO Server image
-  image: minio/minio:RELEASE.2020-08-18T19-41-00Z
+  image: minio/minio:RELEASE.2020-08-26T00-00-49Z
   imagePullPolicy: IfNotPresent
   ## Secret with credentials to be used by MinIO instance.
   credsSecret:
@@ -121,9 +121,9 @@ spec:
   ## is not working properly and needs restart. Kubernetes automatically
   ## restarts the pods if liveness checks fail.
   liveness:
-    initialDelaySeconds: 10
-    periodSeconds: 1
-    timeoutSeconds: 1
+    initialDelaySeconds: 30
+    periodSeconds: 10
+    timeoutSeconds: 10
 
   ## nodeSelector parameters for MinIO Pods. It specifies a map of key-value pairs. For the pod to be
   ## eligible to run on a node, the node must have each of the

diff --git a/examples/tenant-kes.yaml b/examples/tenant-kes.yaml
@@ -37,7 +37,7 @@ spec:
       prometheus.io/port: "9000"
       prometheus.io/scrape: "true"
   ## Registry location and Tag to download MinIO Server image
-  image: minio/minio:RELEASE.2020-08-18T19-41-00Z
+  image: minio/minio:RELEASE.2020-08-26T00-00-49Z
   imagePullPolicy: IfNotPresent
   ## Secret with credentials to be used by MinIO instance.
   credsSecret:
@@ -136,9 +136,9 @@ spec:
   ## is not working properly and needs restart. Kubernetes automatically
   ## restarts the pods if liveness checks fail.
   liveness:
-    initialDelaySeconds: 10
-    periodSeconds: 1
-    timeoutSeconds: 1
+    initialDelaySeconds: 30
+    periodSeconds: 10
+    timeoutSeconds: 10
 
   ## nodeSelector parameters for MinIO Pods. It specifies a map of key-value pairs. For the pod to be
   ## eligible to run on a node, the node must have each of the

diff --git a/examples/tenant-pod-security-policy.yaml b/examples/tenant-pod-security-policy.yaml
@@ -78,7 +78,7 @@ spec:
       prometheus.io/port: "9000"
       prometheus.io/scrape: "true"
   ## Registry location and Tag to download MinIO Server image
-  image: minio/minio:RELEASE.2020-08-18T19-41-00Z
+  image: minio/minio:RELEASE.2020-08-26T00-00-49Z
   ## Service account to be used for all the MinIO Pods
   serviceAccountName: minio-pods
   zones:
@@ -144,8 +144,8 @@ spec:
   ## is not working properly and needs restart. Kubernetes automatically
   ## restarts the pods if liveness checks fail.
   liveness:
-    initialDelaySeconds: 10
-    periodSeconds: 1
+    initialDelaySeconds: 30
+    periodSeconds: 10
   ## nodeSelector parameters for MinIO Pods. It specifies a map of key-value pairs. For the pod to be
   ## eligible to run on a node, the node must have each of the
   ## indicated key-value pairs as labels.

diff --git a/examples/tenant.yaml b/examples/tenant.yaml
@@ -27,7 +27,7 @@ spec:
       prometheus.io/scrape: "true"
 
   ## Registry location and Tag to download MinIO Server image
-  image: minio/minio:RELEASE.2020-08-18T19-41-00Z
+  image: minio/minio:RELEASE.2020-08-26T00-00-49Z
   imagePullPolicy: IfNotPresent
   zones:
     - servers: 4
@@ -101,9 +101,9 @@ spec:
   ## is not working properly and needs restart. Kubernetes automatically
   ## restarts the pods if liveness checks fail.
   liveness:
-    initialDelaySeconds: 10
-    periodSeconds: 1
-    timeoutSeconds: 1
+    initialDelaySeconds: 30
+    periodSeconds: 10
+    timeoutSeconds: 10
 
   ## nodeSelector parameters for MinIO Pods. It specifies a map of key-value pairs. For the pod to be
   ## eligible to run on a node, the node must have each of the

diff --git a/kubectl-minio/README.md b/kubectl-minio/README.md
@@ -41,7 +41,7 @@ example: `kubectl minio tenant create --name tenant1 --secret cred-secret --serv
 Options:
 
 - `--namespace=minio`
-- `--image=minio/minio:RELEASE.2020-08-18T19-41-00Z`
+- `--image=minio/minio:RELEASE.2020-08-26T00-00-49Z`
 - `--storageClass=local`
 - `--kms-secret=secret-name`
 - `--console-secret=secret-name`

diff --git a/kubectl-minio/cmd/helpers/constants.go b/kubectl-minio/cmd/helpers/constants.go
@@ -75,7 +75,7 @@ const (
 	DefaultOperatorImage = "minio/k8s-operator:v3.0.13"
 
 	// DefaultTenantImage is the default MinIO image used while creating tenant
-	DefaultTenantImage = "minio/minio:RELEASE.2020-08-18T19-41-00Z"
+	DefaultTenantImage = "minio/minio:RELEASE.2020-08-26T00-00-49Z"
 
 	// DefaultKESImage is the default KES image used while creating tenant
 	DefaultKESImage = "minio/kes:v0.11.0"

diff --git a/kubectl-minio/cmd/tenant-upgrade.go b/kubectl-minio/cmd/tenant-upgrade.go
@@ -38,7 +38,7 @@ import (
 const (
 	upgradeDesc = `
 'upgrade' command upgrades a MinIO tenant to the specified MinIO version`
-	upgradeExample = `  kubectl minio tenant upgrade --name tenant1 --image minio/minio:RELEASE.2020-08-18T19-41-00Z --namespace tenant1-ns`
+	upgradeExample = `  kubectl minio tenant upgrade --name tenant1 --image minio/minio:RELEASE.2020-08-26T00-00-49Z --namespace tenant1-ns`
 )
 
 type upgradeCmd struct {

diff --git a/pkg/apis/minio.min.io/v1/constants.go b/pkg/apis/minio.min.io/v1/constants.go
@@ -96,13 +96,13 @@ const DefaultZoneName = "zone-0"
 const LivenessPath = "/minio/health/live"
 
 // LivenessInitialDelay specifies the initial delay in calling the liveness endpoint
-const LivenessInitialDelay = 10
+const LivenessInitialDelay = 30 // initial delay of upto 30 seconds
 
 // LivenessPeriod specifies the interval in calling the liveness endpoint
-const LivenessPeriod = 1
+const LivenessPeriod = 10 // once in 10 seconds
 
 // LivenessTimeout specifies the timeout for the liveness probe to expect a response
-const LivenessTimeout = 1
+const LivenessTimeout = 10 // once in 10 seconds
 
 // LivenessFailureThreshold specifies the number of times the liveness probe can fail before
 // the probe to be considered failed.

diff --git a/testing/patching/upgrade-one-zone-step-2.yaml b/testing/patching/upgrade-one-zone-step-2.yaml
@@ -12,7 +12,7 @@ kind: Tenant
 metadata:
   name: upgrade-one-zone
 spec:
-  image: minio/minio:RELEASE.2020-08-18T19-41-00Z
+  image: minio/minio:RELEASE.2020-08-26T00-00-49Z
   zones:
     - servers: 1
       volumesPerServer: 4

diff --git a/testing/patching/upgrade-two-zones-step-2.yaml b/testing/patching/upgrade-two-zones-step-2.yaml
@@ -12,7 +12,7 @@ kind: Tenant
 metadata:
   name: upgrade-two-zones
 spec:
-  image: minio/minio:RELEASE.2020-08-18T19-41-00Z
+  image: minio/minio:RELEASE.2020-08-26T00-00-49Z
   zones:
     - servers: 4
       volumesPerServer: 4