Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only create marketplace publish after container image have been published #2084

Merged
merged 4 commits into from
Apr 24, 2024

Conversation

pjuarezd
Copy link
Member

@pjuarezd pjuarezd commented Apr 19, 2024

This way we do make generate-openshift-manifests after Harsha published the containers.

This is the Release flow proposal

flowchart TD
    A[Creaete Operator release PR\n 'RELEASE=x.x.x.x make release'] --> B(Publish containers)
    B --> C[publish containers\n 'goreleaser release']
    C --> D[Generate redhat catalog manifests PR\n'make generate-openshift-manifests']
    D --> G[Create redhat-marketplace-operators PR\nfor certification]
    G --> I[Merge PR. Automated by RedHat when accepted]
    D --> H[Create certified-operators PR\nfor certification]
    H --> J[Merge PR. Automated by RedHat when accepted]
    I --> N[Merge redhat catalog manifests PR]
    J --> N
    C --> E[Generate helm chart release PR\n'make helm-reindex']
    E --> L[Merge helm chart release PR]
    C --> F[Generate AWS Marketplace release PR in miniohq/eks-integration\n'GENVERSION_OPERATOR=vx.x.x make genversion']
    F --> O[merge eks-integration PR \nTis will publish Operator to AWS Marketplace]
    C --> P[Publish to Azure Marketplace?]
    C --> Q[Publish to Google Marketplace?]

@cniackz cniackz self-requested a review April 19, 2024 19:41
cniackz
cniackz previously approved these changes Apr 19, 2024
@cniackz
Copy link
Contributor

cniackz commented Apr 19, 2024

@pjuarezd, this is a great idea! Thank you very much for the diagram; it explains the process really well. Approved!

@cniackz
Copy link
Contributor

cniackz commented Apr 19, 2024

I just re-executed the 'test-tenant-upgrade' test because it was failing. I have a feeling there might be a change breaking the test, possibly related to a different PR. Let me investigate...

@pjuarezd
Copy link
Member Author

I just re-executed the 'test-tenant-upgrade' test because it was failing. I have a feeling there might be a change breaking the test, possibly related to a different PR. Let me investigate...

Thank you @cniackz!

@cniackz
Copy link
Contributor

cniackz commented Apr 19, 2024

The fix is in this PR: #2085:

Screenshot 2024-04-19 at 4 21 49 PM

cniackz
cniackz previously approved these changes Apr 20, 2024
@cniackz
Copy link
Contributor

cniackz commented Apr 20, 2024

The fix for Tenant Tests On Kind / test-tenant-upgrade (1.21.x, ubuntu-latest) (pull_request) test is in #2087

@cniackz cniackz requested a review from jiuker April 20, 2024 02:31
jiuker
jiuker previously approved these changes Apr 22, 2024
ramondeklein
ramondeklein previously approved these changes Apr 22, 2024
Copy link
Contributor

@ramondeklein ramondeklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but some minor remarks.

olm.sh Show resolved Hide resolved
olm.sh Outdated Show resolved Hide resolved
@ramondeklein
Copy link
Contributor

@pjuarezd Just another suggestion is that you can also use Mermaid to integrate flowcharts (and other diagrams) directly into GitHub (see docs). Live editor is available on https://mermaid.live.

@pjuarezd
Copy link
Member Author

@pjuarezd Just another suggestion is that you can also use Mermaid to integrate flowcharts (and other diagrams) directly into GitHub (see docs). Live editor is available on https://mermaid.live.

Thank you!, I will use it on following graphs!

@pjuarezd pjuarezd dismissed stale reviews from ramondeklein, jiuker, and cniackz via f037e97 April 22, 2024 17:27
@ramondeklein ramondeklein self-requested a review April 22, 2024 18:10
Copy link
Contributor

@ramondeklein ramondeklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…shed

Signed-off-by: pjuarezd <pjuarezd@users.noreply.github.com>
Signed-off-by: pjuarezd <pjuarezd@users.noreply.github.com>
pjuarezd and others added 2 commits April 23, 2024 08:53
Signed-off-by: pjuarezd <pjuarezd@users.noreply.github.com>
Co-authored-by: Ramon de Klein <mail@ramondeklein.nl>
@pjuarezd pjuarezd merged commit 276cb27 into minio:master Apr 24, 2024
25 checks passed
@pjuarezd pjuarezd deleted the split-openshift-publish branch April 24, 2024 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants