A better way to use compiled image in the tests #2087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cniackz
force-pushed
the
better-way-to-change-deployment-image
branch
from
87101a1
to
2dc895e
Compare
cniackz
force-pushed
the
better-way-to-change-deployment-image
branch
from
2dc895e
to
1718ab0
Compare
cniackz
force-pushed
the
better-way-to-change-deployment-image
branch
from
1718ab0
to
b9ee338
Compare
pjuarezd
previously approved these changes
Apr 19, 2024
cniackz
changed the title
cniackz
requested review from
dvaldivia,
allanrogerr,
harshavardhana,
jimmyrmartin,
ramondeklein,
kanagarajkm,
guptaarvindk,
kannappanr,
jiuker and
jinapurapu
|
What is the limit of reviewers?... |
This was referenced Apr 20, 2024
shtripat
previously approved these changes
Apr 20, 2024
allanrogerr
previously approved these changes
Apr 20, 2024
jiuker
previously approved these changes
Apr 22, 2024
You can select up to 15 reviewers, but keep in mind that it also takes a lot of time of the reviewers. |
ramondeklein
previously approved these changes
Apr 22, 2024
Signed-off-by: pjuarezd <pjuarezd@users.noreply.github.com>
pjuarezd
dismissed stale reviews from jiuker, allanrogerr, shtripat, and themself
via
ef158d1
pjuarezd
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story:
The current upgrade test is failing because it cannot patch the current deployments as they are, due to some new restrictions we have imposed. The issue lies in the time-consuming process of maintaining several overlays across different folders just to change an image. Fortunately, there is a much better way to handle this, as illustrated by the following example: