Remove fixed namespace from install #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nitisht
suggested changes
May 18, 2020
There was a problem hiding this comment.
Can you also update the doc here https://github.com/minio/minio-operator#create-operator-and-related-resources
|
@nitisht I think it's implied, most operator install in the same namespace it's being installed to and don't mention the namespace, but I'll add some text regarding this |
dvaldivia
force-pushed
the
remove-namespace-install
branch
from
8bafd5b
to
67a1c4f
Compare
nitisht
approved these changes
May 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing the hardcoded namespace
minio-operator-nsfrom theminio-operator.yamlinstall file.This is to allow the user installing the operator to choose his own namespace via CLI