Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove MINIO_ENDPOINTS env var #1111

Merged
merged 1 commit into from May 6, 2022

Conversation

dvaldivia
Copy link
Collaborator

Removing the MINIO_ENDPOINTS to avoid having to do a statefulset rolling restart when adding new pools

Signed-off-by: Daniel Valdivia 18384552+dvaldivia@users.noreply.github.com

Signed-off-by: Daniel Valdivia <18384552+dvaldivia@users.noreply.github.com>
@harshavardhana
Copy link
Member

Not sure what this change is @dvaldivia can you explain?

@dvaldivia
Copy link
Collaborator Author

yes, since we load the endpoints via webhook and ignore the presence of this environment variable then it's not needed, additionally when we add a new pool, we cause the existing pools to rolling restart since we made a change in this environment variable, if we remove it, we don't need to do that rolling restart, the current mc admin service restart will be enough to have the existing pools adopt the new one @harshavardhana

@harshavardhana
Copy link
Member

yes, since we load the endpoints via webhook and ignore the presence of this environment variable then it's not needed, additionally when we add a new pool, we cause the existing pools to rolling restart since we made a change in this environment variable, if we remove it, we don't need to do that rolling restart, the current mc admin service restart will be enough to have the existing pools adopt the new one @harshavardhana

I see

@dvaldivia dvaldivia merged commit beaf275 into minio:master May 6, 2022
@dvaldivia dvaldivia deleted the remove-minio-endpoints branch May 6, 2022 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants