Remove need to specific selector on labels for MinIO instance and add Current State #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvaldivia
requested review from
harshavardhana,
Alevsk,
nitisht,
Praveenrajmani,
cesnietor and
bexsoft
harshavardhana
approved these changes
May 20, 2020
Alevsk
approved these changes
May 20, 2020
dvaldivia
changed the title
Alevsk
approved these changes
May 20, 2020
harshavardhana
approved these changes
May 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the need to specify the
selectoron theMinIOInstanceCRD. Metadata is still supported, but now optional.We already tag the mcs pod as
v1.min.io/mcs : instance-name-mcsso it's easy to leverage that and the user has one less concern. same for MinIO Instance.In this PR I also made the CRD for
MinIOInstancemore explicit.The fields printed when listing minio instances now shows the current state of the minio instance