Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using service.beta.openshift.io as recommended method #1567

Merged

Conversation

cniackz
Copy link
Contributor

@cniackz cniackz commented Apr 15, 2023

Objective:

To upgrade our Operator versions in the different catalogs. Old annotations are not longer needed, and new annotations has to be used. OpenShift v4 vs OpenShift v3 annotations.

User Story:

  • service.beta.openshift.io/serving-cert-secret-name is the current recommended method used from OpenShift v4 onwards
  • service.alpha.openshift.io/serving-cert-secret-name was the previous method used in OpenShift v3 which is no longer supported in the catalogs as per OpenShift 4.7 has reached its end of life #1565

Links:

@cniackz cniackz changed the title the newer service.beta.openshift.io annotation which is the current r… Using service.beta.openshift.io as current recommended method Apr 15, 2023
@cniackz cniackz changed the title Using service.beta.openshift.io as current recommended method Using service.beta.openshift.io as recommended method Apr 15, 2023
@cniackz cniackz self-assigned this Apr 15, 2023
@cniackz cniackz added the dependencies Pull requests that update a dependency file label Apr 15, 2023
Copy link
Contributor

@shtripat shtripat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cniackz cniackz merged commit 4e436e5 into minio:master Apr 17, 2023
24 checks passed
@cniackz cniackz deleted the update-serving-cert-secret-name-annotations branch April 17, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants