Update Operator Subnet tests to use mocks #1592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some tests were trying to make real requests which was slowing them down
cesnietor
commented
Apr 28, 2023
| @@ -617,14 +617,6 @@ func (suite *TenantTestSuite) TestSetTenantAdministratorsHandlerWithError() { | |||
| suite.assert.True(ok) | |||
| } | |||
|
|
|||
| func (suite *TenantTestSuite) TestSetTenantAdministratorsWithAdminClientError() { | |||
There was a problem hiding this comment.
Removed this cause it was not testing anything.
cesnietor
requested review from
dvaldivia,
cniackz,
reivaj05,
allanrogerr,
bexsoft and
dilverse
pjuarezd
approved these changes
Apr 28, 2023
dvaldivia
approved these changes
May 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tests were trying to make real requests which was slowing them down.
It also updated
getTenantsToRegisterto get all Tenant's minioClients so that we can perform the unittests much quicker. Here we'll be iterating twice but I wanted to accept that so that we could have better tests and be able to run them faster.Before:
After:
Changes
setTenantAdministratorsto have minioClient as input.setTenantAdministratorstests to use mockstenantInterfaceregisterTenantsto usetenantInterfacetenantInterfacesper tenant including their minio ClientTest Steps