Fix timing error leading to a false positive. #1641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the KES pod starts we read from the pod logs the "Root Token" https://github.com/minio/operator/blob/5ef838a70a45d9a7de9a5400be153bcbdb2e5223/testing/console-tenant%2Bkes.sh#L73 However pod running doesn't mean vault process inside already reached that step on the init process. Solution: We wait for the KES deploy Status instead of the pod running. Then we wait for the log message to show, with timeout. If the log message doesn't show, this time is a possitive fail.
Signed-off-by: pjuarezd <pjuarezd@users.noreply.github.com>
reivaj05
approved these changes
Jun 14, 2023
harshavardhana
approved these changes
Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the isse?
When the KES pod starts we read from the pod logs the "Root Token"
operator/testing/console-tenant+kes.sh
Line 73 in 5ef838a
However pod running doesn't mean vault process inside already reached that step on the init process and we end up with an empty root token sometimes
Solution
We wait for the KES deploy Status instead of the pod running, then we wait for the log message to show, with timeout.
If the log message doesn't show, this time is a possitive fail.