Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

display configured kms policies from kes config #1656

Merged
merged 2 commits into from
Jun 22, 2023

Conversation

prakashsvmx
Copy link
Member

@prakashsvmx prakashsvmx commented Jun 21, 2023

display configured kms policies from kes config

Currently the policies are visible only in Raw Edit mode.

Also fix a refresh bug ( once in the tab, just reload the page and the encryption details api is called with undefined for tenant name)

Note: The editing of policy will still be done from Raw Edit mode Tab.

Testing:

have  A running kind cluster with operator/valult deployed 

e.g https://github.com/minio/operator/wiki/Vault,-KES-and-MinIO-Deployed-in-k8s-Cluster

TAG="minio/operator:prakash-test-v3" make all
kind load docker-image docker.io/minio/operator:prakash-test-v3

kubectl kustomize . > operator-test.yaml
# Edit the operator Image  to docker.io/minio/operator:prakash-test-v3
kubectl apply -f operator-test.yaml
#Wait for tenat pods to restart
kubectl minio proxy -n minio-operator

Refresh the tenant and verify that the kms  policies are displayed if available (if not defined it is not displayed)

If there are more policies, they are displayed inside of the scroll able area separated by a line.

how does it look:
With_Policy

No_Policy

Copy link
Contributor

@shtripat shtripat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Verified the changes.

@dvaldivia dvaldivia merged commit 3dbc988 into minio:master Jun 22, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants