Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: PROMETHEUS_NAME env variable seems to be not correctly integrated #1761

Merged
merged 1 commit into from
Sep 7, 2023
Merged

fix: PROMETHEUS_NAME env variable seems to be not correctly integrated #1761

merged 1 commit into from
Sep 7, 2023

Conversation

jiuker
Copy link
Contributor

@jiuker jiuker commented Sep 7, 2023 •
edited

fix: #1760
PROMETHEUS_NAME now it's not really from env.

shtripat
shtripat approved these changes Sep 7, 2023
View reviewed changes
Copy link
Contributor

@shtripat shtripat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@harshavardhana harshavardhana merged commit 0fa58f7 into minio:master Sep 7, 2023
24 checks passed
@bh4t bh4t added the bug fix label Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shtripat shtripat shtripat approved these changes

@kanagarajkm kanagarajkm kanagarajkm approved these changes

@pjuarezd pjuarezd Awaiting requested review from pjuarezd

@harshavardhana harshavardhana Awaiting requested review from harshavardhana

Assignees
No one assigned
Labels
bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PROMETHEUS_NAME env variable seems to be not correctly integrated
5 participants
@jiuker @shtripat @kanagarajkm @harshavardhana @bh4t